Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FEATURE REQUEST] Remove hardcoded tag version from infra config #2780

Closed
10 of 20 tasks
rafzei opened this issue Dec 9, 2021 · 1 comment
Closed
10 of 20 tasks

[FEATURE REQUEST] Remove hardcoded tag version from infra config #2780

rafzei opened this issue Dec 9, 2021 · 1 comment
Assignees
@seriva @przemyslavic
Labels
provider/aws type/improvement type/low-hanging-fruit Good, nice, simple task

Comments

@rafzei
Copy link
Contributor

rafzei commented Dec 9, 2021 •
edited by seriva
Loading

Is your feature request related to a problem? Please describe.
The tag version is hardcoded pointing to the old epicli version and not in all resources. Link

Describe the solution you'd like
The tag should refer to the deployed epicli version and should be assigned to every resource (after epicli apply). We should use the placeholder SET_BY_AUTOMATION in defaults.

Describe alternatives you've considered
None

Additional context
Applied only for aws, but check if we could follow the same approach in azure.

DoD checklist

  • Changelog
    • updated
    • not needed
  • COMPONENTS.md
    • updated
    • not needed
  • Schema
    • updated
    • not needed
  • Backport tasks
    • created
    • not needed
  • Documentation
    • added
    • updated
    • not needed
  • Feature has automated tests
  • Automated tests passed (QA pipelines)
    • apply
    • upgrade
    • backup/restore
  • Idempotency tested
  • All conversations in PR resolved
  • Solution meets requirements and is done according to design doc
  • Usage compliant with license
@seriva seriva self-assigned this Feb 3, 2022
@przemyslavic przemyslavic self-assigned this Feb 4, 2022
@przemyslavic
Copy link
Collaborator

Tested together with #2853.

@seriva seriva closed this as completed Feb 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@seriva seriva

@przemyslavic przemyslavic

Labels
provider/aws type/improvement type/low-hanging-fruit Good, nice, simple task
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@seriva @rafzei @przemyslavic