Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] DaemonSets of Node Exporter and Filebeat deploy in default namespace #1833

Closed
rpudlowski93 opened this issue Nov 5, 2020 · 6 comments

Comments

@rpudlowski93
Copy link
Contributor

Describe the bug
DaemonSets of Node Exporter and FileBeat in case of flag k8s_as_cloud_service: true, will deploy in default namespace which should be clear for user usages.

To Reproduce
Create Epiphany cluster with flag k8s_as_cloud_service: true

Expected behavior
Deploy DaemonSets of Node Exporter and FileBeat in custom namespaces (epi-monitoring and epi-logging)

OS (please complete the following information):

  • Ubuntu/Centos/RHEL

Cloud Environment (please complete the following information):

  • AWS/Azure
@rpudlowski93
Copy link
Contributor Author

Added draft of PR link

  • We need to discuss how the upgrade process should works for the patch

@rpudlowski93
Copy link
Contributor Author

@mkyc mkyc modified the milestones: S20201119, S20201203 Nov 19, 2020
@to-bar to-bar self-assigned this Nov 24, 2020
@to-bar
Copy link
Contributor

to-bar commented Nov 25, 2020

Checked:
epicli upgrade (for cluster in v0.8.0):

15:41:51 INFO cli.engine.ansible.AnsibleCommand - TASK [upgrade : Check if filebeat release exist in default namespace and set fact] *********************************************************************
15:41:51 ERROR cli.engine.ansible.AnsibleCommand - fatal: [tb-module-tests-all-1]: FAILED! => {"msg": "The task includes an option with an undefined variable. The error was: 'specification' is undefined\n\nThe error appears to be in '/workspaces/epiphany/core/src/epicli/clusters/build/tmp/azepi/ansible/roles/upgrade/tasks/filebeat.yml': line 11, column 7, but may\nbe elsewhere in the file depending on the exact syntax problem.\n\nThe offending line appears to be:\n\n\n    - name: Check if filebeat release exist in default namespace and set fact\n      ^ here\n"}

✔️ epicli apply

@rpudlowski93
Copy link
Contributor Author

rpudlowski93 commented Nov 26, 2020

Additional changes done in PR #1878. Please repeat tests

@przemyslavic przemyslavic self-assigned this Dec 2, 2020
@przemyslavic
Copy link
Collaborator

Checked:
✔️ epicli upgrade (from 0.8.0 to develop):

kubectl get pods -A -o wide
NAMESPACE        NAME                                                  READY   STATUS    RESTARTS   AGE    IP           NODE                              NOMINATED NODE   READINESS GATES
epi-logging      filebeat-filebeat-7fw4g                               1/1     Running   0          19m    10.0.16.35   aks-default-xxx-vmss000001   <none>           <none>
epi-logging      filebeat-filebeat-9qj2b                               1/1     Running   0          19m    10.0.16.4    aks-default-xxx-vmss000000   <none>           <none>
epi-monitoring   node-exporter-29kn6                                   1/1     Running   0          18m    10.0.16.4    aks-default-xxx-vmss000000   <none>           <none>
epi-monitoring   node-exporter-tfb9h                                   1/1     Running   0          18m    10.0.16.35   aks-default-xxx-vmss000001   <none>           <none>

Namespaces for DaemonSets have been changed to dedicated ones.

@to-bar
Copy link
Contributor

to-bar commented Dec 2, 2020

Checked:
✔️ epicli apply

kubectl get pods -A
NAMESPACE        NAME                                                  READY   STATUS    RESTARTS   AGE
epi-logging      filebeat-filebeat-55wk5                               1/1     Running   0          45m
epi-logging      filebeat-filebeat-fsggb                               1/1     Running   0          45m
epi-monitoring   node-exporter-5h5s8                                   1/1     Running   0          42m
epi-monitoring   node-exporter-9vwll                                   1/1     Running   0          42m

@mkyc mkyc closed this as completed Dec 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants