Include default vars to filebeat's upgrade role #1878
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
rpudlowski93
commented
Nov 26, 2020
rpudlowski93
commented
- PR releated to failed test in task [BUG] DaemonSets of Node Exporter and Filebeat deploy in default namespace #1833
- Default vars included to filebeat upgrade role from filebeat role
- Filebeat chart name moved from specification to defaults
to-bar
suggested changes
Nov 27, 2020
core/src/epicli/data/common/ansible/playbooks/roles/upgrade/tasks/filebeat.yml
Outdated
Show resolved
Hide resolved
to-bar
previously approved these changes
Nov 27, 2020
|
@rpudlowski93 I found a bug while testing fix for failing upgrades #1875 (PR #1876). I deployed a cluster without kubernetes and helm. During upgrade it fails on task |
|
/azp run |
|
/azp run |
to-bar
reviewed
Dec 1, 2020
core/src/epicli/data/common/ansible/playbooks/roles/upgrade/tasks/filebeat.yml
Outdated
Show resolved
Hide resolved
core/src/epicli/data/common/ansible/playbooks/roles/upgrade/tasks/filebeat.yml
Outdated
Show resolved
Hide resolved
core/src/epicli/data/common/ansible/playbooks/roles/upgrade/tasks/node-exporter.yml
Outdated
Show resolved
Hide resolved
core/src/epicli/data/common/ansible/playbooks/roles/upgrade/tasks/node-exporter.yml
Outdated
Show resolved
Hide resolved
to-bar
approved these changes
Dec 1, 2020
atsikham
approved these changes
Dec 1, 2020
toszo
pushed a commit
to toszo/epiphany
that referenced
this pull request
Dec 5, 2020
* Include default vars to filbeat upgrade role * Upgrade update role of node exporter * Improve logic in upgrade playbooks * Improve var in template file * Change custom to dedicated namespace Co-authored-by: Robert Pudłowski <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.