Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Azure unmanaged disks not suppored by Epiphany but there is misleading setting in the default configuration #1569

Closed
to-bar opened this issue Aug 19, 2020 · 1 comment

Comments

@to-bar
Copy link
Contributor

to-bar commented Aug 19, 2020

Describe the bug
The default specification for Azure VM contains the following setting:

storage_os_disk:
  managed: false

This setting suggests that by default Epiphany will create unmanaged disk but managed disk is created.

To Reproduce
Steps to reproduce the behavior:

  1. Create Azure cluster using the default configuration.
  2. Check terraform.tfstate file, it will contain a value for managed_disk_id.

Expected behavior
Unmanaged disk created or no setting for not supported feature in the default configuration.

Cloud Environment
Cloud Provider: Azure

Additional context
Found in version 0.7.1.

@to-bar to-bar changed the title [BUG] Azure unmanaged disks are not suppored by Epiphany but present in the default configuation [BUG] Azure unmanaged disks are not suppored by Epiphany but there is measliding setting in the default configuation Aug 19, 2020
@to-bar to-bar changed the title [BUG] Azure unmanaged disks are not suppored by Epiphany but there is measliding setting in the default configuation [BUG] Azure unmanaged disks not suppored by Epiphany but there is measliding setting in default configuation Aug 19, 2020
@to-bar to-bar changed the title [BUG] Azure unmanaged disks not suppored by Epiphany but there is measliding setting in default configuation [BUG] Azure unmanaged disks not suppored by Epiphany but there is measliding setting in the default configuration Aug 19, 2020
@to-bar to-bar changed the title [BUG] Azure unmanaged disks not suppored by Epiphany but there is measliding setting in the default configuration [BUG] Azure unmanaged disks not suppored by Epiphany but there is misleading setting in the default configuration Aug 19, 2020
@seriva seriva self-assigned this Jan 10, 2022
@cicharka
Copy link
Contributor

This PR is changing default setting to true:

  storage_os_disk:
    managed: true

seriva added a commit that referenced this issue Jan 26, 2022
- Bumped Terraform from 0.12.6 to 1.1.3.
- Bumped azurerm provider from 1.38 to 2.91.
- Bumped AWS provider from 2.26 to 3.70.1
- Updated azurerm provider scripts
- Updated AWS provider scripts
- Updated Azure-cli from 2.29 to 2.32
- Fix for #1569.
- Added Terraform manual update documentation
- Added incompatible terraform check
- Added changelog.
- Bumped version to 2.0.0dev
- Apply terraform fmt to enforce standard on templates
@seriva seriva closed this as completed Jan 27, 2022
rafzei pushed a commit to rafzei/epiphany that referenced this issue Feb 1, 2022
- Bumped Terraform from 0.12.6 to 1.1.3.
- Bumped azurerm provider from 1.38 to 2.91.
- Bumped AWS provider from 2.26 to 3.70.1
- Updated azurerm provider scripts
- Updated AWS provider scripts
- Updated Azure-cli from 2.29 to 2.32
- Fix for hitachienergy#1569.
- Added Terraform manual update documentation
- Added incompatible terraform check
- Added changelog.
- Bumped version to 2.0.0dev
- Apply terraform fmt to enforce standard on templates
rafzei pushed a commit to rafzei/epiphany that referenced this issue Feb 1, 2022
- Bumped Terraform from 0.12.6 to 1.1.3.
- Bumped azurerm provider from 1.38 to 2.91.
- Bumped AWS provider from 2.26 to 3.70.1
- Updated azurerm provider scripts
- Updated AWS provider scripts
- Updated Azure-cli from 2.29 to 2.32
- Fix for hitachienergy#1569.
- Added Terraform manual update documentation
- Added incompatible terraform check
- Added changelog.
- Bumped version to 2.0.0dev
- Apply terraform fmt to enforce standard on templates
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants