Terraform major upgrade #2852
Merged
Terraform major upgrade #2852
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
seriva
commented
Jan 10, 2022
•
seriva
commented
- Bumped Terraform from 0.12.6 to 1.1.3.
- Bumped azurerm provider from 1.38 to 2.91.
- Bumped AWS provider from 2.26 to 3.70.1
- Updated azurerm provider scripts
- Updated AWS provider scripts
- Updated Azure-cli from 2.29 to 2.32
- Fix for [BUG] Azure unmanaged disks not suppored by Epiphany but there is misleading setting in the default configuration #1569.
- Added Terraform manual update documentation
- Added incompatible terraform check
- Added changelog.
- Bumped version to 2.0.0dev
- Apply terraform fmt to enforce standard on templates
5 tasks
atsikham
suggested changes
Jan 14, 2022
There was a problem hiding this comment.
In addition to minor changes suggested: did you use terraform fmt? If no, it might be the right PR to do. Continue to check.
terraform/azure/infrastructure/network-interface-security-group-association.j2
Outdated
Show resolved
Hide resolved
cicharka
reviewed
Jan 17, 2022
erzetpe
suggested changes
Jan 17, 2022
Co-authored-by: Anatoli Tsikhamirau <[email protected]>
Done. |
erzetpe
suggested changes
Jan 19, 2022
Co-authored-by: erzetpe <[email protected]>
Applied to both AWS and Azure templates. |
erzetpe
approved these changes
Jan 19, 2022
erzetpe
previously approved these changes
Jan 19, 2022
|
/azp run |
* query_yes_no for assert_incompatible_terraform added
This template when paresd by TerraformTemplateGenerator is failing due to: `ERROR epicli - 'cli.helpers.ObjDict.ObjDict object' has no attribute 'storage_container'`. Removal of commented lines helps parser to fulfil its job.
|
/azp run |
This was referenced Jan 21, 2022
erzetpe
approved these changes
Jan 24, 2022
|
Tested with: |
|
Tested:
|
rafzei
pushed a commit
to rafzei/epiphany
that referenced
this pull request
Feb 1, 2022
- Bumped Terraform from 0.12.6 to 1.1.3. - Bumped azurerm provider from 1.38 to 2.91. - Bumped AWS provider from 2.26 to 3.70.1 - Updated azurerm provider scripts - Updated AWS provider scripts - Updated Azure-cli from 2.29 to 2.32 - Fix for hitachienergy#1569. - Added Terraform manual update documentation - Added incompatible terraform check - Added changelog. - Bumped version to 2.0.0dev - Apply terraform fmt to enforce standard on templates
rafzei
pushed a commit
to rafzei/epiphany
that referenced
this pull request
Feb 1, 2022
- Bumped Terraform from 0.12.6 to 1.1.3. - Bumped azurerm provider from 1.38 to 2.91. - Bumped AWS provider from 2.26 to 3.70.1 - Updated azurerm provider scripts - Updated AWS provider scripts - Updated Azure-cli from 2.29 to 2.32 - Fix for hitachienergy#1569. - Added Terraform manual update documentation - Added incompatible terraform check - Added changelog. - Bumped version to 2.0.0dev - Apply terraform fmt to enforce standard on templates
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.