Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify how infections are estimated #571

Merged
merged 2 commits into from
Feb 22, 2024
Merged

Clarify how infections are estimated #571

merged 2 commits into from
Feb 22, 2024

Conversation

jamesmbaazam
Copy link
Contributor

Description

This PR closes #522.

The process of estimating infections was previously described in a way to suggest that it was imputed, but has now been clarified to say that it is estimated as a latent variable.

Initial submission checklist

  • My PR is based on a package issue and I have explicitly linked it.
  • I have tested my changes locally (using devtools::test() and devtools::check()).
  • I have added or updated unit tests where necessary.
  • I have updated the documentation if required and rebuilt docs if yes (using devtools::document()).
  • I have followed the established coding standards (and checked using lintr::lint_package()).
  • I have added a news item linked to this PR.

After the initial Pull Request

  • I have reviewed Checks for this PR and addressed any issues as far as I am able.

@jamesmbaazam jamesmbaazam self-assigned this Feb 21, 2024
@jamesmbaazam jamesmbaazam added the documentation Improvements or additions to documentation label Feb 21, 2024
@jamesmbaazam
Copy link
Contributor Author

Not sure if this is NEWs worthy.

Copy link
Contributor

@sbfnk sbfnk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor rephrasing suggeted

README.Rmd Outdated Show resolved Hide resolved
@sbfnk sbfnk force-pushed the clarify-README-wording branch from f03e7a0 to 163a857 Compare February 22, 2024 13:32
@sbfnk sbfnk enabled auto-merge (squash) February 22, 2024 13:32
@sbfnk sbfnk merged commit a9f88cf into main Feb 22, 2024
9 of 10 checks passed
@sbfnk sbfnk deleted the clarify-README-wording branch February 22, 2024 14:50
sbfnk added a commit that referenced this pull request May 3, 2024
* Clarify how infections are estimated

* Correct grammar.

Co-authored-by: Sebastian Funk <[email protected]>

---------

Co-authored-by: Sebastian Funk <[email protected]>
sbfnk added a commit that referenced this pull request May 3, 2024
* Clarify how infections are estimated

* Correct grammar.

Co-authored-by: Sebastian Funk <[email protected]>

---------

Co-authored-by: Sebastian Funk <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Clarify how infections are treated in README summary
2 participants