-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
switch to directly calculated growth rate and extend model options, take 2 #345
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seabbs
force-pushed
the
update_growth_and_generation
branch
from
January 27, 2023 14:05
40709d2
to
8fe772a
Compare
sbfnk
force-pushed
the
update_growth_and_generation
branch
from
July 4, 2023 20:01
1e5e88c
to
998cadd
Compare
Merged
sbfnk
force-pushed
the
main
branch
2 times, most recently
from
February 19, 2024 20:09
7568882
to
23229a8
Compare
To do for being able to revisit this:
|
This was referenced Mar 12, 2024
Closed
sbfnk
force-pushed
the
main
branch
4 times, most recently
from
May 3, 2024 19:32
3b7431c
to
6a52995
Compare
implements suggestions by @hsbadr See #213 (comment) #213 (comment) #213 (comment) For now not implementing comparison to the approximate growth rate as this seems quite a specific use case that could also be done outside the stan model. Also not implementing any approximate growth rate from seeding time - instead minimum seeding time is now set to 1, so the last seeding time is used to calculate the first growth rate.
…erything on the log scale as long as possible)
sbfnk
force-pushed
the
update_growth_and_generation
branch
from
May 17, 2024 07:05
998cadd
to
e543808
Compare
Closing as most suggestions in here have now made it into |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Attempts to resurrect #307 as work in progress. Copying text from there:
This PR is meant to supersede #213 and #214. It
master
Things left to do:
backcalc_opts()
from all inputrt_opts()
from all inputgeneration_time_opts()
inside ofprocess_opts()
as an argument.