New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: ensure types generate properly for release #18

Merged

kentcdodds merged 1 commit into epicweb-dev:main from anthonyhagi:main

Jan 19, 2025

Contributor

anthonyhagi commented Jan 19, 2025

The type generation step was not excluding the node_modules folder. I've added --skipLibCheck and this resolves the following issue:

I think a good next step would be to add a pr.yml workflow to run through type checking so we don't run into these issues in the future


          fix: ensure types generate properly for release

7d8db61

kentcdodds approved these changes

View reviewed changes

Member

kentcdodds left a comment

Thanks!

kentcdodds merged commit 171e0f4 into epicweb-dev:main

2 checks passed

anthonyhagi mentioned this pull request

feat: add loose type hinting for hash algorithm options #17

Merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet