Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add robots.txt and sitemap.xml #456

Merged
merged 4 commits into from
Sep 21, 2023
Merged

Add robots.txt and sitemap.xml #456

merged 4 commits into from
Sep 21, 2023

Conversation

lpsinger
Copy link
Contributor

See remix-run/remix#2912 (reply in thread)

Test Plan

Checklist

  • Tests updated
  • Docs updated

Screenshots

@lpsinger
Copy link
Contributor Author

I'm not sure what's going wrong when I run npm run dev:

$ npm run dev

> predev
> npm run build:icons --silent


> dev
> remix dev -c "node ./server/dev-server.js" --manual


 💿  remix dev

 info  building...
 info  built (8.4s)
6:30:10 PM [tsx] rerunning
Debugger listening on ws://127.0.0.1:9229/8911dd2a-b040-4bac-ac18-7207cb0b3a3c
For help, see: https://nodejs.org/en/docs/inspector
TypeError: Cannot read properties of undefined (reading 'startsWith')
TypeError: Cannot read properties of undefined (reading 'startsWith')
    at file:///Users/lpsinger/src/epic-stack/tests/mocks/github.ts:1:2646

Copy link
Member

@kentcdodds kentcdodds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this! I can fix the issue you're having. But I'm concerned about something else.

Also, we probably should add some documentation.

app/routes/_seo+/sitemap[.]xml.ts Outdated Show resolved Hide resolved
Copy link
Member

@kentcdodds kentcdodds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a bunch! This is very useful!

@kentcdodds kentcdodds merged commit 45f6322 into epicweb-dev:main Sep 21, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants