fix confetti bug #446
Closed
fix confetti bug #446
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kentcdodds
reviewed
Sep 15, 2023
|
Also, thanks! |
|
You're welcome! I'll give it a try. |
|
Well, the last update was on May 20, 2022. I'll fork and fix it. I'll post the new version here. There's also another bug related to viewport width: when the confetti animation is launched, if you scroll, the confetti will disappear, which I think is solved using the same solution. |
|
Closing this until a new package is ready. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a bug with the Confetti component: if you resize the window, the Confetti component keeps occupying the original width and height, creating vertical and horizontal scrolling.
Video showing the issue: https://youtu.be/G2d8-KYU7j0
Changes: