Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add test cases for note images #420

Merged
merged 6 commits into from
Oct 31, 2023

Conversation

arpitdalal
Copy link
Contributor

Adding tests for note images.
The following tests are included:

  1. Users can create note with an image
  2. Users can create note with multiple images
  3. Users can edit note image
  4. Users can delete note image

Test Plan

Checklist

  • Tests updated
  • Docs updated

Screenshots

Copy link
Member

@kentcdodds kentcdodds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for working on this!

I would like to improve some of the locators and other things if possible.

tests/e2e/note-images.test.ts Outdated Show resolved Hide resolved
tests/e2e/note-images.test.ts Outdated Show resolved Hide resolved
tests/e2e/note-images.test.ts Outdated Show resolved Hide resolved
@kentcdodds
Copy link
Member

Could you rebase your changes on main?

@arpitdalal arpitdalal force-pushed the pr/add-note-images-test branch from c700738 to da00327 Compare September 19, 2023 16:25
@kentcdodds
Copy link
Member

Thanks again! Could you revert changes to the package lock? I don't think that file should have changes

Copy link
Member

@kentcdodds kentcdodds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@kentcdodds kentcdodds force-pushed the pr/add-note-images-test branch from 909a8b2 to c934acd Compare October 31, 2023 22:40
@kentcdodds kentcdodds merged commit e41809c into epicweb-dev:main Oct 31, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants