Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unconditionally check for non-closed-loop parameters in writeFloat64 #15

Merged
merged 3 commits into from
Oct 25, 2022
Merged

Unconditionally check for non-closed-loop parameters in writeFloat64 #15

merged 3 commits into from
Oct 25, 2022

Conversation

kmpeters
Copy link
Contributor

Unconditionally check for non-closed-loop parameters in writeFloat64. Hopefully this fixes #14

@kmpeters
Copy link
Contributor Author

Possible problem with this pull request: the base class method gets called every time one of the closed-loop parameters changes:

motorPIGCS2/pigcs2App/src/PIasynController.cpp

Line 368 in 85fe00e

status = asynMotorController::writeFloat64(pasynUser, value);

@kmpeters kmpeters merged commit 771849a into master Oct 25, 2022
@kmpeters kmpeters deleted the issue14 branch October 25, 2022 22:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Closed-loop logic breaks writeFloat64
1 participant
@kmpeters