Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Jog improvements #43

Merged
merged 2 commits into from
May 8, 2023
Merged

Jog improvements #43

merged 2 commits into from
May 8, 2023

Conversation

kmpeters
Copy link
Contributor

@kmpeters kmpeters commented May 8, 2023

Changes:

  1. Use the jog velocity (JVAL) and acceleration (JAR)
  2. Pass the jog velocity to the jog command rather than change the normal move velocity
  3. Removed the unused jog direction parameter
  4. Changed the jogDirection record from an ao to a longout

kmpeters added 2 commits May 8, 2023 10:42
@kmpeters
Multiple changes to moveVelocity:
dd1381c 
1. Use the user-specified acceleration for both acceleration
   and deceleration.
2. Pass the user-specified velocity to the jog command,
   rather than change the normal velocity.
@kmpeters
Removed the unused jog direction parameter
94a01d6
@tim-speight
Copy link
Contributor

Looks good

@kmpeters kmpeters merged commit 2babedc into master May 8, 2023
@kmpeters kmpeters deleted the jog-improvements branch May 8, 2023 19:39
@kmpeters kmpeters mentioned this pull request Jun 23, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kmpeters @tim-speight