-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
motorRecord.cc: Jogging against to LVIO in LVIO #99
motorRecord.cc: Jogging against to LVIO in LVIO #99
Conversation
aaeaeb8
to
3103563
Compare
How to reproduce? |
Note: A test was added here: |
Is the new version just to correct the problem description? If so, that isn't necessary. I can just make a note in the merge comment. |
I would love to have the commit msg to be in sync with the problem description. |
Sounds good. |
When jogging has stopped because the motor is close to a softlimit, the record seems to be locked up when the same jog button is pressed again. The user must release the jog button, before doing any other action. STOP doesn't help, neither does jog into the opposite direction work. Solution: Clear the JOGF and JOGR button in the record.
3103563
to
9e5b543
Compare
Now I updated the commit message (with a forced push) |
I wasn't able to reproduce the non-zero MIP when attempting to jog into a limit after a limit violation occurs, but I did confirm that the JOGF/JOGR fields weren't immediately reset when the limit violation occurs. With the change in the pull request the JOGF/JOGR fields get reset to zero when LVIO goes to one. If a user was holding down a jog button on a MEDM screen, this means the JOGF or JOGR field will be set to zero a second time when the button is released, but this shouldn't have any negative consequences. |
Merge up to a21b1ccb_ Merge: c09b49c 9e5b543 Date: Mon Aug 20 14:50:07 2018 -0500 Merge pull request epics-modules#99 from EuropeanSpallationSource/JOG_LVIO_JOG_nolockup
No description provided.