Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

motorRecord.cc: Jogging against to LVIO in LVIO #99

Merged

Conversation

tboegi
Copy link
Contributor

@tboegi tboegi commented Jul 3, 2018

No description provided.

@tboegi tboegi force-pushed the JOG_LVIO_JOG_nolockup branch from aaeaeb8 to 3103563 Compare July 3, 2018 08:50
@kmpeters kmpeters self-assigned this Jul 12, 2018
@tboegi
Copy link
Contributor Author

tboegi commented Jul 13, 2018

How to reproduce?
Press JOGF, wait until the record stops the motor, close to HLM.
Press JOGF again.
Look at the MIP field. In my case MIP was not 0, but JOG_REQ was still on.

@tboegi
Copy link
Contributor Author

tboegi commented Jul 15, 2018

Note:
The record does not lock up, so that the commit msg is wrong.
The JOGR/JOGF field stay 1, and need to be reset to 0 to "unlock".
I will send a new version, in some weeks or so.

A test was added here:
https://bitbucket.org/europeanspallationsource/m-epics-ethercatmc/src/6f71147bec5b35f326b4e3097f2a97fe6c193fa6/test/nose_tests/121_Record-JOGF_DLY_HLM.py?at=torstenb%2F180629_dev&fileviewer=file-view-default

@kmpeters
Copy link
Member

kmpeters commented Aug 2, 2018

Note:
The record does not lock up, so that the commit msg is wrong.
The JOGR/JOGF field stay 1, and need to be reset to 0 to "unlock".
I will send a new version, in some weeks or so.

Is the new version just to correct the problem description? If so, that isn't necessary. I can just make a note in the merge comment.

@tboegi
Copy link
Contributor Author

tboegi commented Aug 3, 2018

I would love to have the commit msg to be in sync with the problem description.
Right now it isn't, so please let me submit a better commit.
And thanks for offering help

@kmpeters
Copy link
Member

kmpeters commented Aug 3, 2018

Sounds good.

When jogging has stopped because the motor is close to a softlimit,
the record seems to be locked up when the same jog button is pressed again.

The user must release the jog button, before doing any other action.
STOP doesn't help, neither does jog into the opposite direction work.

Solution:
Clear the JOGF and JOGR button in the record.
@tboegi tboegi force-pushed the JOG_LVIO_JOG_nolockup branch from 3103563 to 9e5b543 Compare August 20, 2018 07:10
@tboegi
Copy link
Contributor Author

tboegi commented Aug 20, 2018

Now I updated the commit message (with a forced push)

@kmpeters
Copy link
Member

I wasn't able to reproduce the non-zero MIP when attempting to jog into a limit after a limit violation occurs, but I did confirm that the JOGF/JOGR fields weren't immediately reset when the limit violation occurs.

With the change in the pull request the JOGF/JOGR fields get reset to zero when LVIO goes to one. If a user was holding down a jog button on a MEDM screen, this means the JOGF or JOGR field will be set to zero a second time when the button is released, but this shouldn't have any negative consequences.

@kmpeters kmpeters merged commit a21b1cc into epics-modules:master Aug 20, 2018
tboegi added a commit to EuropeanSpallationSource/motor that referenced this pull request Oct 2, 2018
Merge up to a21b1ccb_
Merge: c09b49c 9e5b543
Date:   Mon Aug 20 14:50:07 2018 -0500
Merge pull request epics-modules#99 from EuropeanSpallationSource/JOG_LVIO_JOG_nolockup
@kmpeters kmpeters added this to the R6-11 milestone Aug 13, 2019
@tboegi tboegi deleted the JOG_LVIO_JOG_nolockup branch September 18, 2019 16:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants