Record: motor record DLY and STOP problem #60
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix the problem that the record gets stuck when STOP is pressed while the record is in MIP_DELAY (and the motor is standing still, so that there is no record processing). Currently the MIP_DELAY bits are set to 0, when a STOP is issued. As the motor already hase stopped, the DMOV field never goes to 1. There are 2 possible solutions here: a) STOP wins: pmr->dmov = FALSE; MARK(M_DMOV); b) DELAY wins Send a STOP to the controller (just to be sure), but wait for the DELAY. a) may cause probles later, whena new positionioning is done after the STOP and a new DELAY is triggered. As the old callback is still active, it may be executed before the new callback. And the time will be too short. For this reason go with b) http://www.aps.anl.gov/epics/tech-talk/2015/msg01786.php
|
This seems like a reasonable change. If @rsluiter concurs, I'll merge the pull request. |
|
Confirmed the behaviour and the fix. Good to go. |
kmpeters
added a commit
that referenced
this pull request
Jun 6, 2018
…P-problem Record: motor record DLY and STOP problem (cherry picked from commit 90bb52f)
tboegi
added a commit
to EuropeanSpallationSource/motor
that referenced
this pull request
Oct 2, 2018
Merge up to 90bb52f: "Merge: f3d4e0f 38186d0" Merge pull request epics-modules#60 from EuropeanSpallationSource/record-DLYandSTOP-problem The code in motorRecord.cc is already there, but uses devSupStop() instead of hand-made INIT_MSG(), WRITE_MSG() and SEND_MSG(). And that is why we have: Conflicts: motorApp/MotorSrc/motorRecord.cc
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix the problem that the record gets stuck when STOP is
pressed while the record is in MIP_DELAY (and the motor
is standing still, so that there is no record processing).
Currently the MIP_DELAY bits are set to 0, when a STOP is issued.
As the motor already hase stopped, the DMOV field never goes to 1.
There are 2 possible solutions here:
a) STOP wins:
pmr->dmov = FALSE;
MARK(M_DMOV);
b) DELAY wins
Send a STOP to the controller (just to be sure), but wait for the DELAY.
a) may cause probles later, whena new positionioning is done after the STOP
and a new DELAY is triggered.
As the old callback is still active, it may be executed before the new
callback. And the time will be too short.
For this reason go with b)
http://www.aps.anl.gov/epics/tech-talk/2015/msg01786.php