Align the table header to the table when labels are used #63
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ReportIf no labels are added everything stays the same:
If labels are added the header indents correctly:
It doesn't matter how many elements are included:
All other labelled fields look the same:
|
evalott100
force-pushed
the
allow_labels_on_tables
branch
from
12a44e5 to
27d9667
Compare
|
We agreed it is not worth the extra logic to allow row labels of static tables to be hidden. The diff to the expected test files is to add these row labels. |
evalott100
force-pushed
the
allow_labels_on_tables
branch
from
27d9667 to
5122ada
Compare
The table header is now also indented if the table is given labels. Regenerated table output in tests.
evalott100
force-pushed
the
allow_labels_on_tables
branch
from
5122ada to
42fbbb3
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #63 +/- ##
==========================================
+ Coverage 88.51% 88.55% +0.04%
==========================================
Files 22 22
Lines 1358 1363 +5
==========================================
+ Hits 1202 1207 +5
Misses 156 156 ☔ View full report in Codecov by Sentry. |
GDYendell
approved these changes
Nov 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #49
The table header is now also indented
if the table is given labels.
Regenerated table output in tests.