Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation context menu #819

Merged
merged 20 commits into from
Sep 30, 2024
Merged

Conversation context menu #819

merged 20 commits into from
Sep 30, 2024

Conversation

lourou
Copy link
Member

@lourou lourou commented Sep 26, 2024

Conversation context menu implementation with auxiliary preview

Closes #727

- Implement drag-to-dismiss functionality
- Wrap component with GestureHandlerRootView
- Update to use current Gesture API
…isplay

- Remove default export from ConversationReadOnly
- Auxiliary display container styling
- Hide scrollbar for read-only conversation preview
@lourou lourou force-pushed the lr/conversation-context-menu branch 2 times, most recently from 0450190 to 17457cc Compare September 27, 2024 07:56
@lourou lourou marked this pull request as ready for review September 27, 2024 09:57
@lourou lourou requested a review from a team as a code owner September 27, 2024 09:57
@saulmc saulmc requested a review from thierryskoda September 27, 2024 11:24
Copy link
Collaborator

@thierryskoda thierryskoda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small comment but the rest looks good to me!

components/ConversationContextMenu.tsx Outdated Show resolved Hide resolved
@thierryskoda
Copy link
Collaborator

Missing some context maybe but also what we could do is in Chat create a components just for the messages so we can display that instead of the whole Chat component. Might help with performance.

@lourou lourou force-pushed the lr/conversation-context-menu branch from e2debc2 to aff36c6 Compare September 30, 2024 08:14
@lourou
Copy link
Member Author

lourou commented Sep 30, 2024

Missing some context maybe but also what we could do is in Chat create a components just for the messages so we can display that instead of the whole Chat component. Might help with performance.

I've started working on a Chat component refactor on a separate branch/PR, so we can improve perf on the auxiliary preview.

@lourou lourou merged commit 4afee17 into main Sep 30, 2024
3 checks passed
@lourou lourou deleted the lr/conversation-context-menu branch September 30, 2024 10:34
@lourou lourou mentioned this pull request Sep 30, 2024
technoplato pushed a commit that referenced this pull request Dec 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Conversation context menu
2 participants