Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup privy/onboarding/unused code #1584

Merged
merged 6 commits into from
Feb 1, 2025
Merged

Cleanup privy/onboarding/unused code #1584

merged 6 commits into from
Feb 1, 2025

Conversation

technoplato
Copy link
Collaborator

@technoplato technoplato commented Jan 30, 2025

making our new privy work a clean start

just need to fix this tiny bug: https://www.loom.com/share/092f94425fb941f2ab1212a80226848f?sid=e9522ef8-5c48-466b-99c9-82a0735dd05c

@technoplato technoplato requested a review from a team as a code owner January 30, 2025 22:57
Copy link
Collaborator

@thierryskoda thierryskoda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes siir! 🚀 🗑️

@@ -31,6 +31,12 @@ export const useCreatePasskey = () => {
}, [setStatusString, signupState.status]);

const handleCreateAccountWithPasskey = useCallback(async () => {
const isEnrolledInBiometrics = await LocalAuthentication.isEnrolledAsync();
if (!isEnrolledInBiometrics) {
alert("Please activate Face ID or Touch ID to use Passkey");
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixes #1578

@technoplato technoplato merged commit 762b0d6 into main Feb 1, 2025
6 checks passed
@technoplato technoplato deleted the ml/cleanup-passkey branch February 1, 2025 17:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants