Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix App Check iOS production app bundle id, pod update #1469

Merged
merged 1 commit into from
Jan 3, 2025

Conversation

lourou
Copy link
Member

@lourou lourou commented Jan 3, 2025

Summary by CodeRabbit

  • Configuration Updates
    • Updated iOS bundle identifier for the production environment
    • Modified Google services configuration for the app
    • Removed specific resource bundle references in Xcode project settings

@lourou lourou requested a review from a team as a code owner January 3, 2025 15:12
Copy link
Contributor

coderabbitai bot commented Jan 3, 2025

Walkthrough

The pull request involves modifications to two iOS project files. The Xcode project configuration file (project.pbxproj) has been updated to remove references to specific resource bundles from the build phases. Simultaneously, the Google Services configuration file (GoogleService-Info-prod.plist) has been modified to update the bundle identifier and Google App ID, potentially indicating a change in the application's configuration for production environment.

Changes

File Change Summary
ios/Converse.xcodeproj/project.pbxproj Removed references to RCT-Folly_privacy.bundle and glog_privacy.bundle from [CP] Copy Pods Resources build phase
ios/Google Services/GoogleService-Info-prod.plist Updated BUNDLE_ID from com.converse.prod to com.converse.native
Updated GOOGLE_APP_ID to a new identifier

Possibly related PRs

  • diff #1277: Modifies project.pbxproj with similar removals of resource bundle references from build phases

Poem

🐰 Hop, hop, through Xcode's maze,
Bundles vanish, configs blaze!
Native paths and services new,
A rabbit's code review breakthrough 🚀
Configurations dance with glee! 🌟


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 640a2f1 and c3a534b.

⛔ Files ignored due to path filters (1)
  • ios/Podfile.lock is excluded by !**/*.lock
📒 Files selected for processing (2)
  • ios/Converse.xcodeproj/project.pbxproj (0 hunks)
  • ios/Google Services/GoogleService-Info-prod.plist (2 hunks)
💤 Files with no reviewable changes (1)
  • ios/Converse.xcodeproj/project.pbxproj
🔇 Additional comments (2)
ios/Google Services/GoogleService-Info-prod.plist (2)

12-12: Confirm and align this bundle ID with Apple Developer Portal.
This change from the previous com.converse.prod to com.converse.native looks correct for the new environment. Verify that the project settings and provisioning profiles in the Apple Developer Portal are updated correspondingly.


28-28: Ensure consistency with Firebase console settings.
Changing the GOOGLE_APP_ID to the new identifier likely requires corresponding updates in the Firebase console. Double-check that the new app ID matches the configured iOS app in your Firebase project.


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@lourou lourou merged commit ce16f35 into main Jan 3, 2025
2 checks passed
@lourou lourou deleted the lr/appcheck-ios-prod-fix branch January 3, 2025 15:23
@lourou
Copy link
Member Author

lourou commented Jan 3, 2025

Closes #1467

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants