Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: appcheck ios #1369
feat: appcheck ios #1369
Changes from all commits
e3a7113
83ffcae
c080ea9
ad52d21
502c921
3b5f901
f9c7064
7236612
d74a82c
3de6015
71f3b2e
c664b28
42e50e0
d70c25d
29fa001
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
Check warning on line 80 in App.tsx
Check warning on line 83 in App.tsx
Check warning on line 127 in App.tsx
Check warning on line 145 in App.tsx
Check warning on line 6 in app.config.ts
Check warning on line 10 in app.config.ts
Check warning on line 17 in app.config.ts
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hardcoded development bundle identifier may cause issues in production
The bundle identifier is hardcoded to "com.converse.dev" for both iOS and Android. This should be environment-specific to support different builds.
Consider using environment variables or the existing environment checks:
Similar change needed for Android package name.
Also applies to: 46-46