Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: reply message in composer and messages #1252

Merged
merged 1 commit into from
Nov 25, 2024

Conversation

thierryskoda
Copy link
Collaborator

@thierryskoda thierryskoda commented Nov 25, 2024

Summary by CodeRabbit

Release Notes

  • New Features

    • Enhanced handling of remote attachments in chat messages.
    • New functionality to identify static attachment messages.
    • Improved reply message structure with support for various content types.
  • Bug Fixes

    • Refined error handling and loading states for attachment previews.
  • Chores

    • Updated constants and import structures for clarity and functionality.
  • Style

    • Added new properties for message bubble and attachment styling in themes.

@thierryskoda thierryskoda requested a review from a team as a code owner November 25, 2024 16:12
@thierryskoda thierryskoda merged commit f6120dc into feature/v3-split Nov 25, 2024
Copy link
Contributor

coderabbitai bot commented Nov 25, 2024

Caution

Review failed

The pull request is closed.

Walkthrough

The pull request introduces significant enhancements to the handling of remote attachments across various components in the chat application. Key changes include the addition of a new hook for fetching remote attachments, refactoring of existing components to streamline attachment rendering, and updates to utility functions for message type identification. The overall structure and logic of the message handling system have been improved, particularly in how messages with attachments are processed and displayed.

Changes

File Path Change Summary
components/Chat/Attachment/AttachmentMessagePreview.tsx - Added useRemoteAttachment hook for fetching remote attachments.
- Refactored RemoteAttachmentMessagePreview to RemoteImage with updated props.
- Modified fetchAttachment for better local attachment handling.
components/Chat/Message/Message.utils.tsx - Updated isStaticAttachmentMessage logic.
- Introduced useCurrentAccountInboxId and getCurrentUserAccountInboxId functions.
components/Chat/Message/V3Message.tsx - Replaced RemoteAttachmentMessagePreview with RemoteAttachmentPreview and RemoteImage.
- Enhanced reply message handling for remote attachments.
features/conversation-list/hooks/useMessageText.ts - Added handling for static attachment messages in useMessageText.
features/conversation/composer/composer.tsx - Updated send function to include replyingToMessageId.
- Introduced ReplyPreviewEndContent and ReplyPreviewMessageContent components.
features/conversation/conversation-context.tsx - Updated sendMessage to create a new conversation if none exists.
theme/border-radius.ts - Added message property with bubble and attachment sub-properties.
theme/colorsDark.ts - Introduced nestedReplyFromMe property in bubbles object.
theme/layout.ts - Added comment regarding potential future changes to onboardingScreenPadding.
theme/spacing.ts - Added message object with replyMessage padding properties.
utils/xmtpRN/attachments.ts - Renamed MAX_SMALL_ATTACHMENT_SIZE to MAX_AUTOMATIC_DOWNLOAD_ATTACHMENT_SIZE.

Possibly related PRs

  • fix: Render Frame on initial send #1067: The changes in this PR involve the handling of message types and rendering logic, which may relate to the modifications in attachment handling and rendering in the main PR.
  • refactor and fix modal #1094: This PR includes updates to the Chat component, which may interact with the changes made to attachment rendering in the main PR.
  • feat: remove split screen stuff #1105: The removal of split-screen logic in this PR could affect how messages and attachments are displayed, potentially linking it to the changes in the main PR.
  • fix: Fixed Buttons for Certain cases #1127: The updates to button functionality and navigation may relate to how attachments are interacted with in the chat interface, connecting it to the main PR's changes.

Suggested labels

2.0.7

Suggested reviewers

  • alexrisch

Poem

🐰 In the chat where messages flow,
Attachments now have room to grow.
With hooks and previews, bright and new,
Each message shines, a clearer view.
So hop along, let’s share the cheer,
For every update brings us near! 🌟


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@thierryskoda thierryskoda deleted the ts/message-refactoring-reply-message branch November 25, 2024 16:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant