-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow ethereum deeplinks inside frames #1198
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: alexrisch <[email protected]>
Co-authored-by: alexrisch <[email protected]>
Performance Comparison ReportSignificant Changes To DurationThere are no entries Meaningless Changes To DurationShow entries
Show details
Render Count ChangesThere are no entries Render IssuesThere are no entries Added ScenariosThere are no entries Removed ScenariosThere are no entries |
alexrisch
added a commit
that referenced
this pull request
Nov 19, 2024
* [create-pull-request] automated change (#1122) Co-authored-by: alexrisch <[email protected]> * fix: Set is Frame when ending with slash (#1129) Added handling to clean url Updated to use util function * Allow ethereum deeplinks inside frames (#1198) * Allow ethereum deeplinks inside frames * Set and new file * Bump app json * [create-pull-request] automated change (#1195) Co-authored-by: alexrisch <[email protected]> * [create-pull-request] automated change (#1197) Co-authored-by: alexrisch <[email protected]> --------- Co-authored-by: Noé Malzieu <[email protected]> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: alexrisch <[email protected]> * Fix linking for ethereum: links (#1208) --------- Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: alexrisch <[email protected]> Co-authored-by: Noé Malzieu <[email protected]>
alexrisch
added a commit
that referenced
this pull request
Nov 19, 2024
* [create-pull-request] automated change (#1122) Co-authored-by: alexrisch <[email protected]> * fix: Set is Frame when ending with slash (#1129) Added handling to clean url Updated to use util function * Allow ethereum deeplinks inside frames (#1198) * Allow ethereum deeplinks inside frames * Set and new file * Bump app json * [create-pull-request] automated change (#1195) Co-authored-by: alexrisch <[email protected]> * [create-pull-request] automated change (#1197) Co-authored-by: alexrisch <[email protected]> --------- Co-authored-by: Noé Malzieu <[email protected]> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: alexrisch <[email protected]> * Fix linking for ethereum: links (#1208) --------- Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: alexrisch <[email protected]> Co-authored-by: Noé Malzieu <[email protected]>
Koleok
pushed a commit
that referenced
this pull request
Nov 27, 2024
* Allow ethereum deeplinks inside frames * Set and new file * Bump app json * [create-pull-request] automated change (#1195) Co-authored-by: alexrisch <[email protected]> * [create-pull-request] automated change (#1197) Co-authored-by: alexrisch <[email protected]> --------- Co-authored-by: Noé Malzieu <[email protected]> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: alexrisch <[email protected]>
technoplato
pushed a commit
that referenced
this pull request
Dec 17, 2024
* [create-pull-request] automated change (#1122) Co-authored-by: alexrisch <[email protected]> * fix: Set is Frame when ending with slash (#1129) Added handling to clean url Updated to use util function * Allow ethereum deeplinks inside frames (#1198) * Allow ethereum deeplinks inside frames * Set and new file * Bump app json * [create-pull-request] automated change (#1195) Co-authored-by: alexrisch <[email protected]> * [create-pull-request] automated change (#1197) Co-authored-by: alexrisch <[email protected]> --------- Co-authored-by: Noé Malzieu <[email protected]> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: alexrisch <[email protected]> * Fix linking for ethereum: links (#1208) --------- Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: alexrisch <[email protected]> Co-authored-by: Noé Malzieu <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.