Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow ethereum deeplinks inside frames #1198

Merged
merged 5 commits into from
Nov 14, 2024
Merged

Conversation

alexrisch
Copy link
Collaborator

No description provided.

@alexrisch alexrisch requested a review from a team as a code owner November 14, 2024 01:48
Copy link
Contributor

Performance Comparison Report

  • Current: d18cc2c - 2024-11-14 01:51:34Z
  • Baseline: main (4a68dd4) - 2024-11-14 01:50:56Z

Significant Changes To Duration

There are no entries

Meaningless Changes To Duration

Show entries
Name Type Duration Count
Avatar Image 10 runs render 1.1 ms → 1.3 ms (+0.2 ms, +18.2%) 🔴 1 → 1
Avatar Image 50 runs render 1.0 ms → 1.0 ms 1 → 1
Empty Avatar 10 runs render 0.9 ms → 1.0 ms (+0.1 ms, +11.1%) 1 → 1
Empty Avatar 50 runs render 0.8 ms → 0.8 ms (-0.0 ms, -5.0%) 1 → 1
Show details
Name Type Duration Count
Avatar Image 10 runs render Baseline
Mean: 1.1 ms
Stdev: 0.6 ms (51.6%)
Runs: 2 0 1 1 1 1 1 2 1 1
Warmup runs: 2

Current
Mean: 1.3 ms
Stdev: 0.5 ms (37.2%)
Runs: 2 2 1 1 1 1 1 2 1 1
Warmup runs: 2
Baseline
Mean: 1
Stdev: 0 (0.0%)
Runs: 1 1 1 1 1 1 1 1 1 1
Render issues:

Current
Mean: 1
Stdev: 0 (0.0%)
Runs: 1 1 1 1 1 1 1 1 1 1
Render issues:
Avatar Image 50 runs render Baseline
Mean: 1.0 ms
Stdev: 0.2 ms (19.0%)
Runs: 1 1 1 1 2 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 2 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1
Warmup runs: 2

Current
Mean: 1.0 ms
Stdev: 0.2 ms (19.0%)
Runs: 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 2 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 2 1 1 1 1 1 1 1 1 1 1
Warmup runs: 1
Baseline
Mean: 1
Stdev: 0 (0.0%)
Runs: 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1
Render issues:

Current
Mean: 1
Stdev: 0 (0.0%)
Runs: 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1
Render issues:
Empty Avatar 10 runs render Baseline
Mean: 0.9 ms
Stdev: 0.3 ms (35.1%)
Runs: 1 1 1 1 1 1 1 1 1 0
Warmup runs: 73

Current
Mean: 1.0 ms
Stdev: 0.0 ms (0.0%)
Runs: 1 1 1 1 1 1 1 1 1 1
Warmup runs: 8
Baseline
Mean: 1
Stdev: 0 (0.0%)
Runs: 1 1 1 1 1 1 1 1 1 1
Render issues:

Current
Mean: 1
Stdev: 0 (0.0%)
Runs: 1 1 1 1 1 1 1 1 1 1
Render issues:
Empty Avatar 50 runs render Baseline
Mean: 0.8 ms
Stdev: 0.4 ms (50.5%)
Runs: 1 1 0 1 0 1 1 1 1 1 1 1 1 1 0 0 1 1 1 1 1 1 1 1 0 0 1 1 1 1 0 1 1 1 1 1 0 1 1 0 1 1 1 1 0 1 1 1 1 1
Warmup runs: 1

Current
Mean: 0.8 ms
Stdev: 0.4 ms (56.8%)
Runs: 1 1 1 1 1 1 1 1 1 1 1 0 1 0 1 0 1 1 0 1 1 1 1 1 1 0 0 0 0 1 1 1 1 1 1 1 1 1 1 0 1 1 1 1 1 1 1 0 0 0
Warmup runs: 1
Baseline
Mean: 1
Stdev: 0 (0.0%)
Runs: 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1
Render issues:

Current
Mean: 1
Stdev: 0 (0.0%)
Runs: 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1
Render issues:

Render Count Changes

There are no entries

Render Issues

There are no entries

Added Scenarios

There are no entries

Removed Scenarios

There are no entries

Generated by 🚫 dangerJS against 8a1c3aa

@alexrisch alexrisch merged commit bac8634 into main Nov 14, 2024
5 checks passed
@alexrisch alexrisch deleted the noe/updates-support-eth-scheme branch November 14, 2024 14:14
alexrisch added a commit that referenced this pull request Nov 19, 2024
* [create-pull-request] automated change (#1122)

Co-authored-by: alexrisch <[email protected]>

* fix: Set is Frame when ending with slash (#1129)

Added handling to clean url
Updated to use util function

* Allow ethereum deeplinks inside frames (#1198)

* Allow ethereum deeplinks inside frames

* Set and new file

* Bump app json

* [create-pull-request] automated change (#1195)

Co-authored-by: alexrisch <[email protected]>

* [create-pull-request] automated change (#1197)

Co-authored-by: alexrisch <[email protected]>

---------

Co-authored-by: Noé Malzieu <[email protected]>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: alexrisch <[email protected]>

* Fix linking for ethereum: links (#1208)

---------

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: alexrisch <[email protected]>
Co-authored-by: Noé Malzieu <[email protected]>
alexrisch added a commit that referenced this pull request Nov 19, 2024
* [create-pull-request] automated change (#1122)

Co-authored-by: alexrisch <[email protected]>

* fix: Set is Frame when ending with slash (#1129)

Added handling to clean url
Updated to use util function

* Allow ethereum deeplinks inside frames (#1198)

* Allow ethereum deeplinks inside frames

* Set and new file

* Bump app json

* [create-pull-request] automated change (#1195)

Co-authored-by: alexrisch <[email protected]>

* [create-pull-request] automated change (#1197)

Co-authored-by: alexrisch <[email protected]>

---------

Co-authored-by: Noé Malzieu <[email protected]>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: alexrisch <[email protected]>

* Fix linking for ethereum: links (#1208)

---------

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: alexrisch <[email protected]>
Co-authored-by: Noé Malzieu <[email protected]>
Koleok pushed a commit that referenced this pull request Nov 27, 2024
* Allow ethereum deeplinks inside frames

* Set and new file

* Bump app json

* [create-pull-request] automated change (#1195)

Co-authored-by: alexrisch <[email protected]>

* [create-pull-request] automated change (#1197)

Co-authored-by: alexrisch <[email protected]>

---------

Co-authored-by: Noé Malzieu <[email protected]>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: alexrisch <[email protected]>
technoplato pushed a commit that referenced this pull request Dec 17, 2024
* [create-pull-request] automated change (#1122)

Co-authored-by: alexrisch <[email protected]>

* fix: Set is Frame when ending with slash (#1129)

Added handling to clean url
Updated to use util function

* Allow ethereum deeplinks inside frames (#1198)

* Allow ethereum deeplinks inside frames

* Set and new file

* Bump app json

* [create-pull-request] automated change (#1195)

Co-authored-by: alexrisch <[email protected]>

* [create-pull-request] automated change (#1197)

Co-authored-by: alexrisch <[email protected]>

---------

Co-authored-by: Noé Malzieu <[email protected]>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: alexrisch <[email protected]>

* Fix linking for ethereum: links (#1208)

---------

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: alexrisch <[email protected]>
Co-authored-by: Noé Malzieu <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants