Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: fix icon button styling #1076

Merged
merged 1 commit into from
Oct 23, 2024
Merged

feat: fix icon button styling #1076

merged 1 commit into from
Oct 23, 2024

Conversation

thierryskoda
Copy link
Collaborator

No description provided.

@thierryskoda thierryskoda requested a review from a team as a code owner October 23, 2024 13:47
@github-actions GitHub Actions
Copy link
Contributor

Performance Comparison Report

  • Current: 03f347e - 2024-10-23 13:51:09Z
  • Baseline: release/2.0.8 (c1319ea) - 2024-10-23 13:50:31Z

Significant Changes To Duration

There are no entries

Meaningless Changes To Duration

Show entries
Name Type Duration Count
Avatar Image 10 runs render 1.0 ms → 1.2 ms (+0.2 ms, +20.0%) 🔴 1 → 1
Avatar Image 50 runs render 1.1 ms → 1.0 ms (-0.0 ms, -3.8%) 1 → 1
Empty Avatar 10 runs render 1.1 ms → 0.9 ms (-0.2 ms, -18.2%) 🟢 1 → 1
Empty Avatar 50 runs render 0.9 ms → 0.8 ms (-0.1 ms, -13.6%) 1 → 1
Show details
Name Type Duration Count
Avatar Image 10 runs render Baseline
Mean: 1.0 ms
Stdev: 0.5 ms (47.1%)
Runs: 2 1 1 1 1 1 1 1 1 0
Warmup runs: 2

Current
Mean: 1.2 ms
Stdev: 0.6 ms (52.7%)
Runs: 2 1 1 0 1 1 1 1 2 2
Warmup runs: 2		 Baseline
Mean: 1
Stdev: 0 (0.0%)
Runs: 1 1 1 1 1 1 1 1 1 1
Render issues:

Current
Mean: 1
Stdev: 0 (0.0%)
Runs: 1 1 1 1 1 1 1 1 1 1
Render issues:
Avatar Image 50 runs render Baseline
Mean: 1.1 ms
Stdev: 0.3 ms (29.6%)
Runs: 1 1 1 1 0 1 1 1 1 1 1 1 1 1 1 2 1 1 1 1 2 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 2 2 1 1 1 1 1 1 1 1 1 1 1
Warmup runs: 1

Current
Mean: 1.0 ms
Stdev: 0.3 ms (31.3%)
Runs: 1 1 1 2 1 1 1 1 1 1 1 1 1 1 2 1 1 1 1 1 1 1 1 1 1 0 0 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 2
Warmup runs: 2		 Baseline
Mean: 1
Stdev: 0 (0.0%)
Runs: 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1
Render issues:

Current
Mean: 1
Stdev: 0 (0.0%)
Runs: 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1
Render issues:
Empty Avatar 10 runs render Baseline
Mean: 1.1 ms
Stdev: 0.3 ms (28.7%)
Runs: 2 1 1 1 1 1 1 1 1 1
Warmup runs: 70

Current
Mean: 0.9 ms
Stdev: 0.3 ms (35.1%)
Runs: 1 1 1 1 1 1 0 1 1 1
Warmup runs: 7		 Baseline
Mean: 1
Stdev: 0 (0.0%)
Runs: 1 1 1 1 1 1 1 1 1 1
Render issues:

Current
Mean: 1
Stdev: 0 (0.0%)
Runs: 1 1 1 1 1 1 1 1 1 1
Render issues:
Empty Avatar 50 runs render Baseline
Mean: 0.9 ms
Stdev: 0.3 ms (37.3%)
Runs: 1 1 1 1 1 1 1 1 1 1 1 1 1 0 1 1 1 1 1 1 1 1 0 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 0 1 1 1 1 1 1 0 0 1 0 1
Warmup runs: 1

Current
Mean: 0.8 ms
Stdev: 0.4 ms (56.8%)
Runs: 1 1 1 1 1 1 1 0 1 0 0 1 1 1 1 1 1 1 1 0 1 1 1 1 1 0 1 0 0 1 0 1 1 0 1 1 1 1 1 1 1 0 1 0 1 1 1 1 0 1
Warmup runs: 1		 Baseline
Mean: 1
Stdev: 0 (0.0%)
Runs: 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1
Render issues:

Current
Mean: 1
Stdev: 0 (0.0%)
Runs: 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1
Render issues:

Render Count Changes

There are no entries

Render Issues

There are no entries

Added Scenarios

There are no entries

Removed Scenarios

There are no entries

Generated by 🚫 dangerJS against 729086a

alexrisch
alexrisch reviewed Oct 23, 2024
View reviewed changes
design-system/IconButton/IconButton.example.tsx
import { VStack } from "../VStack";
import { IconButton } from "./IconButton";

export const IconButtonExample = memo(function IconButtonExample() {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is Storyboard worthwhile? Or some sort of example screen?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Every time I added Storyboard in my app it was always overkill. Even when we were 10. So for now I'm just doing those so that if ever we need to see we can just import those.

Might find a better solution later or even delete them TBH.

@thierryskoda thierryskoda merged commit 65b3644 into release/2.0.8 Oct 23, 2024
6 checks passed
@thierryskoda thierryskoda deleted the ts/design-system-icon-button branch October 23, 2024 17:42
@alexrisch alexrisch mentioned this pull request Oct 23, 2024
Closed
alexrisch pushed a commit that referenced this pull request Oct 24, 2024
@thierryskoda @alexrisch
fix icon button styling (#1076)
5d87302
alexrisch pushed a commit that referenced this pull request Oct 25, 2024
@thierryskoda @alexrisch
fix icon button styling (#1076)
6065428
alexrisch pushed a commit that referenced this pull request Oct 28, 2024
@thierryskoda @alexrisch
fix icon button styling (#1076)
6b6a402
alexrisch added a commit that referenced this pull request Nov 1, 2024
@nmalzieu @saulmc
@github-actions @alexrisch @thierryskoda @lourou
Noe/transactional frames mobile (#1100)
ed7bdef 
* Reorg evm utils

* Revoke other installations outside of onboarding (Coinbase Wallet only for now)

* WIP: wallet drawer

* Use privy signer for revoke

* Ability to select different wallets for external wallet setup

* Rebase on main, fix import

* Rebase on main

* useXmtpSigner hook

* comment

* autoconnect even if kill the app

* Keep link between app & wallet as long as possible

* Fix dark mode & use translate

* Updated revocation strings

Removes references to the unfamiliar XMTP/MLS term "installation".

* First working flow of tx frames

* WIP: tx frame preview

* Tx frame preview & trigger

* Fix import

* UI for transactions

* Disable switch chain step for now

* Only coinbase for now

* Fix typing

* Increment version numbers

* Fix chain switching

* [create-pull-request] automated change (#1016)

Co-authored-by: nmalzieu <[email protected]>

* [create-pull-request] automated change (#1017)

Co-authored-by: nmalzieu <[email protected]>

* Display error

* feat: Group Sync Notifications (#950)

Added Handling for Group Sync Notifications on Android & iOS

Co-authored-by: Alex Risch <[email protected]>

* chore: Add Min system version for macos warning (#994)

Added LSMinimumSystemVersion to 12.0 from app store connect emails

* feat: Show Profile info in join requests (#999)

Added React Query Profiles query
Added batshit for batching queries
Added helper hooks

* Make tx error work

* [create-pull-request] automated change (#1019)

Co-authored-by: nmalzieu <[email protected]>

* fix: Android Push Notificaition parsing (#1018)

Safely parse notification

* chore: Increment versions

* feat: Android Variants (#984)

* feat: Android Variants

Added Android Variants
Moved folder structures
Removed Android build scripts used to update new variant info
Aligned eas.json profiles
Added new manifest and strings for Android resource merger

* missed file commit

* [create-pull-request] automated change (#1024)

Co-authored-by: alexrisch <[email protected]>

* feat: more design system stuff (#1006)

* wip

* more color fix

* fix hstack file name

* fix hstack file name

* fix hstack file name

* fix types + fix button + add more theme stuff

* fix button

* more fixes

* fix snapshots

* wip

* bottom sheet wip

* fix button component and refactor bottom sheet into multiple files

* more bottom sheet fixes

* clean up

* fix

* Simulation endpoint

* remove bottom sheet example stuff

* Move TransactionPreview

* Using design-system

* cleanup

* Split transactionPreview in multiple components

* More UI for tx simulation

* feat: Android Variants (#984)

* feat: Android Variants

Added Android Variants
Moved folder structures
Removed Android build scripts used to update new variant info
Aligned eas.json profiles
Added new manifest and strings for Android resource merger

* missed file commit

* [create-pull-request] automated change (#1024)

Co-authored-by: alexrisch <[email protected]>

* feat: more design system stuff (#1006)

* wip

* more color fix

* fix hstack file name

* fix hstack file name

* fix hstack file name

* fix types + fix button + add more theme stuff

* fix button

* more fixes

* fix snapshots

* wip

* bottom sheet wip

* fix button component and refactor bottom sheet into multiple files

* more bottom sheet fixes

* clean up

* fix

* remove bottom sheet example stuff

* Rolled-up reactions (#1037)

* Always show reactions outside of the message bubble

No matter which content type it is

* useMemo on useStyles

* Revert "useMemo on useStyles"

This reverts commit 93657c4.

* Use app theme and start implementing values in styles

* WIP Implement new styling and colors to reaction bubbles

* Update reactors container outer margin

* Remove avatars in reaction bubbles; apply new design system for styling; use alias to import the theme

* Add `borderWidth` to theme

* Use border radius and border width from theme

* Implement rolled up reactions

* Move const

* Show top 3 reactions

* Put comment back in

* Change border color to match the background for user's own reactions

* Change chat background to theme `colors.background.surface`

* Set new background to `surface` also in App, Chat, and Input

* Remove the export default, put the memo inline with the component

* More design system implementation

- Replace `<View>` with `HStack` and `VStack` components
- Use the `Text` from the design-system not from `react-native`

* Upgrade Thirdweb, make sure to pass a max amount of chains to walletconnect

* Fix typing

* feat: TextField design system (#1074)

* add TextField and fix IconButton

* delete old button

* feat: Pressable Group Updates

Added handling when pressing a display name in the group updated messages

* Add Tests

* Correct styles on pressables

* Update pressable style

* update to design system

Fixed tsconfig
Added util to create text styles
Updated Chat Group Updated message to match design system
Added ParsedText component

* fix tests

* recs for cleaner (#1012)

* Update to follow design system

* Remove unused component

* Update pods

* Placeholder image

* Color update & cleanup

* feat: Android Variants (#984)

* feat: Android Variants

Added Android Variants
Moved folder structures
Removed Android build scripts used to update new variant info
Aligned eas.json profiles
Added new manifest and strings for Android resource merger

* missed file commit

* [create-pull-request] automated change (#1024)

Co-authored-by: alexrisch <[email protected]>

* feat: more design system stuff (#1006)

* wip

* more color fix

* fix hstack file name

* fix hstack file name

* fix hstack file name

* fix types + fix button + add more theme stuff

* fix button

* more fixes

* fix snapshots

* wip

* bottom sheet wip

* fix button component and refactor bottom sheet into multiple files

* more bottom sheet fixes

* clean up

* fix

* remove bottom sheet example stuff

* Rolled-up reactions (#1037)

* Always show reactions outside of the message bubble

No matter which content type it is

* useMemo on useStyles

* Revert "useMemo on useStyles"

This reverts commit 93657c4.

* Use app theme and start implementing values in styles

* WIP Implement new styling and colors to reaction bubbles

* Update reactors container outer margin

* Remove avatars in reaction bubbles; apply new design system for styling; use alias to import the theme

* Add `borderWidth` to theme

* Use border radius and border width from theme

* Implement rolled up reactions

* Move const

* Show top 3 reactions

* Put comment back in

* Change border color to match the background for user's own reactions

* Change chat background to theme `colors.background.surface`

* Set new background to `surface` also in App, Chat, and Input

* Remove the export default, put the memo inline with the component

* More design system implementation

- Replace `<View>` with `HStack` and `VStack` components
- Use the `Text` from the design-system not from `react-native`

* feat: TextField design system (#1074)

* add TextField and fix IconButton

* delete old button

* feat: Pressable Group Updates

Added handling when pressing a display name in the group updated messages

* Add Tests

* Correct styles on pressables

* Update pressable style

* update to design system

Fixed tsconfig
Added util to create text styles
Updated Chat Group Updated message to match design system
Added ParsedText component

* fix tests

* recs for cleaner (#1012)

* Update to follow design system

* fix icon button styling (#1076)

* More UI & full flow

* fix: Xmtp Engine Rerenders, Race Conditions, Crashes  (#1036)

* fix: Xmtp Engine Rerenders, Race Conditions, Crashes

Refactored Xmtp Engine to be mostly outside of React Context
Adds subscriptions
Moves app state into folder and adds new app state util

* Moved cron to class component

* fix: EAS Build Fixes (#1099)

* remove testflight action

* fix eas

* oops

* Set to remote

* add platform checks

* fixes

* Expo is great

---------

Co-authored-by: Thierry <[email protected]>

* Only show changes that concern me

* feat: Android Variants (#984)

* feat: Android Variants

Added Android Variants
Moved folder structures
Removed Android build scripts used to update new variant info
Aligned eas.json profiles
Added new manifest and strings for Android resource merger

* missed file commit

* [create-pull-request] automated change (#1024)

Co-authored-by: alexrisch <[email protected]>

* feat: more design system stuff (#1006)

* wip

* more color fix

* fix hstack file name

* fix hstack file name

* fix hstack file name

* fix types + fix button + add more theme stuff

* fix button

* more fixes

* fix snapshots

* wip

* bottom sheet wip

* fix button component and refactor bottom sheet into multiple files

* more bottom sheet fixes

* clean up

* fix

* remove bottom sheet example stuff

* Rolled-up reactions (#1037)

* Always show reactions outside of the message bubble

No matter which content type it is

* useMemo on useStyles

* Revert "useMemo on useStyles"

This reverts commit 93657c4.

* Use app theme and start implementing values in styles

* WIP Implement new styling and colors to reaction bubbles

* Update reactors container outer margin

* Remove avatars in reaction bubbles; apply new design system for styling; use alias to import the theme

* Add `borderWidth` to theme

* Use border radius and border width from theme

* Implement rolled up reactions

* Move const

* Show top 3 reactions

* Put comment back in

* Change border color to match the background for user's own reactions

* Change chat background to theme `colors.background.surface`

* Set new background to `surface` also in App, Chat, and Input

* Remove the export default, put the memo inline with the component

* More design system implementation

- Replace `<View>` with `HStack` and `VStack` components
- Use the `Text` from the design-system not from `react-native`

* feat: TextField design system (#1074)

* add TextField and fix IconButton

* delete old button

* feat: Pressable Group Updates

Added handling when pressing a display name in the group updated messages

* Add Tests

* Correct styles on pressables

* Update pressable style

* update to design system

Fixed tsconfig
Added util to create text styles
Updated Chat Group Updated message to match design system
Added ParsedText component

* fix tests

* recs for cleaner (#1012)

* Update to follow design system

* fix icon button styling (#1076)

* fix: Xmtp Engine Rerenders, Race Conditions, Crashes  (#1036)

* fix: Xmtp Engine Rerenders, Race Conditions, Crashes

Refactored Xmtp Engine to be mostly outside of React Context
Adds subscriptions
Moves app state into folder and adds new app state util

* Moved cron to class component

* fix: EAS Build Fixes (#1099)

* remove testflight action

* fix eas

* oops

* Set to remote

* add platform checks

* fixes

* Expo is great

---------

Co-authored-by: Thierry <[email protected]>

* Feature: Navigation Refactor (#1025)

navigation refactor

* feat: remove web stuff (#1102)

remove web stuff

* rebase 2.0.8 (#1105)

* fix: Sync Account on Add (#1104)

* fix: Sync Account on Add

Added subscription for accounts store

* Safety

* fix: Run Android profile (#1107)

* [create-pull-request] automated change (#1106)

Co-authored-by: alexrisch <[email protected]>

* fix open conversation

* [create-pull-request] automated change (#1110)

Co-authored-by: thierryskoda <[email protected]>

* [create-pull-request] automated change (#1115)

Co-authored-by: alexrisch <[email protected]>

* Remove duplicated component

* Add missing tx preview component

* Fix snapshot

* Fix tests

* Comments from PR + fix tx frame success

* move default chain to its own file

* move default chain to its own file

---------

Co-authored-by: Saul Carlin <[email protected]>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: nmalzieu <[email protected]>
Co-authored-by: Alex Risch <[email protected]>
Co-authored-by: Alex Risch <[email protected]>
Co-authored-by: alexrisch <[email protected]>
Co-authored-by: Thierry Skoda <[email protected]>
Co-authored-by: Thierry <[email protected]>
Co-authored-by: Louis Rouffineau <[email protected]>
Co-authored-by: thierryskoda <[email protected]>
technoplato pushed a commit that referenced this pull request Dec 17, 2024
@thierryskoda @alexrisch
fix icon button styling (#1076)
d9ef782
technoplato pushed a commit that referenced this pull request Dec 17, 2024
@nmalzieu @saulmc
@github-actions @alexrisch @thierryskoda @lourou
Noe/transactional frames mobile (#1100)
85d7db7 
* Reorg evm utils

* Revoke other installations outside of onboarding (Coinbase Wallet only for now)

* WIP: wallet drawer

* Use privy signer for revoke

* Ability to select different wallets for external wallet setup

* Rebase on main, fix import

* Rebase on main

* useXmtpSigner hook

* comment

* autoconnect even if kill the app

* Keep link between app & wallet as long as possible

* Fix dark mode & use translate

* Updated revocation strings

Removes references to the unfamiliar XMTP/MLS term "installation".

* First working flow of tx frames

* WIP: tx frame preview

* Tx frame preview & trigger

* Fix import

* UI for transactions

* Disable switch chain step for now

* Only coinbase for now

* Fix typing

* Increment version numbers

* Fix chain switching

* [create-pull-request] automated change (#1016)

Co-authored-by: nmalzieu <[email protected]>

* [create-pull-request] automated change (#1017)

Co-authored-by: nmalzieu <[email protected]>

* Display error

* feat: Group Sync Notifications (#950)

Added Handling for Group Sync Notifications on Android & iOS

Co-authored-by: Alex Risch <[email protected]>

* chore: Add Min system version for macos warning (#994)

Added LSMinimumSystemVersion to 12.0 from app store connect emails

* feat: Show Profile info in join requests (#999)

Added React Query Profiles query
Added batshit for batching queries
Added helper hooks

* Make tx error work

* [create-pull-request] automated change (#1019)

Co-authored-by: nmalzieu <[email protected]>

* fix: Android Push Notificaition parsing (#1018)

Safely parse notification

* chore: Increment versions

* feat: Android Variants (#984)

* feat: Android Variants

Added Android Variants
Moved folder structures
Removed Android build scripts used to update new variant info
Aligned eas.json profiles
Added new manifest and strings for Android resource merger

* missed file commit

* [create-pull-request] automated change (#1024)

Co-authored-by: alexrisch <[email protected]>

* feat: more design system stuff (#1006)

* wip

* more color fix

* fix hstack file name

* fix hstack file name

* fix hstack file name

* fix types + fix button + add more theme stuff

* fix button

* more fixes

* fix snapshots

* wip

* bottom sheet wip

* fix button component and refactor bottom sheet into multiple files

* more bottom sheet fixes

* clean up

* fix

* Simulation endpoint

* remove bottom sheet example stuff

* Move TransactionPreview

* Using design-system

* cleanup

* Split transactionPreview in multiple components

* More UI for tx simulation

* feat: Android Variants (#984)

* feat: Android Variants

Added Android Variants
Moved folder structures
Removed Android build scripts used to update new variant info
Aligned eas.json profiles
Added new manifest and strings for Android resource merger

* missed file commit

* [create-pull-request] automated change (#1024)

Co-authored-by: alexrisch <[email protected]>

* feat: more design system stuff (#1006)

* wip

* more color fix

* fix hstack file name

* fix hstack file name

* fix hstack file name

* fix types + fix button + add more theme stuff

* fix button

* more fixes

* fix snapshots

* wip

* bottom sheet wip

* fix button component and refactor bottom sheet into multiple files

* more bottom sheet fixes

* clean up

* fix

* remove bottom sheet example stuff

* Rolled-up reactions (#1037)

* Always show reactions outside of the message bubble

No matter which content type it is

* useMemo on useStyles

* Revert "useMemo on useStyles"

This reverts commit 93657c4.

* Use app theme and start implementing values in styles

* WIP Implement new styling and colors to reaction bubbles

* Update reactors container outer margin

* Remove avatars in reaction bubbles; apply new design system for styling; use alias to import the theme

* Add `borderWidth` to theme

* Use border radius and border width from theme

* Implement rolled up reactions

* Move const

* Show top 3 reactions

* Put comment back in

* Change border color to match the background for user's own reactions

* Change chat background to theme `colors.background.surface`

* Set new background to `surface` also in App, Chat, and Input

* Remove the export default, put the memo inline with the component

* More design system implementation

- Replace `<View>` with `HStack` and `VStack` components
- Use the `Text` from the design-system not from `react-native`

* Upgrade Thirdweb, make sure to pass a max amount of chains to walletconnect

* Fix typing

* feat: TextField design system (#1074)

* add TextField and fix IconButton

* delete old button

* feat: Pressable Group Updates

Added handling when pressing a display name in the group updated messages

* Add Tests

* Correct styles on pressables

* Update pressable style

* update to design system

Fixed tsconfig
Added util to create text styles
Updated Chat Group Updated message to match design system
Added ParsedText component

* fix tests

* recs for cleaner (#1012)

* Update to follow design system

* Remove unused component

* Update pods

* Placeholder image

* Color update & cleanup

* feat: Android Variants (#984)

* feat: Android Variants

Added Android Variants
Moved folder structures
Removed Android build scripts used to update new variant info
Aligned eas.json profiles
Added new manifest and strings for Android resource merger

* missed file commit

* [create-pull-request] automated change (#1024)

Co-authored-by: alexrisch <[email protected]>

* feat: more design system stuff (#1006)

* wip

* more color fix

* fix hstack file name

* fix hstack file name

* fix hstack file name

* fix types + fix button + add more theme stuff

* fix button

* more fixes

* fix snapshots

* wip

* bottom sheet wip

* fix button component and refactor bottom sheet into multiple files

* more bottom sheet fixes

* clean up

* fix

* remove bottom sheet example stuff

* Rolled-up reactions (#1037)

* Always show reactions outside of the message bubble

No matter which content type it is

* useMemo on useStyles

* Revert "useMemo on useStyles"

This reverts commit 93657c4.

* Use app theme and start implementing values in styles

* WIP Implement new styling and colors to reaction bubbles

* Update reactors container outer margin

* Remove avatars in reaction bubbles; apply new design system for styling; use alias to import the theme

* Add `borderWidth` to theme

* Use border radius and border width from theme

* Implement rolled up reactions

* Move const

* Show top 3 reactions

* Put comment back in

* Change border color to match the background for user's own reactions

* Change chat background to theme `colors.background.surface`

* Set new background to `surface` also in App, Chat, and Input

* Remove the export default, put the memo inline with the component

* More design system implementation

- Replace `<View>` with `HStack` and `VStack` components
- Use the `Text` from the design-system not from `react-native`

* feat: TextField design system (#1074)

* add TextField and fix IconButton

* delete old button

* feat: Pressable Group Updates

Added handling when pressing a display name in the group updated messages

* Add Tests

* Correct styles on pressables

* Update pressable style

* update to design system

Fixed tsconfig
Added util to create text styles
Updated Chat Group Updated message to match design system
Added ParsedText component

* fix tests

* recs for cleaner (#1012)

* Update to follow design system

* fix icon button styling (#1076)

* More UI & full flow

* fix: Xmtp Engine Rerenders, Race Conditions, Crashes  (#1036)

* fix: Xmtp Engine Rerenders, Race Conditions, Crashes

Refactored Xmtp Engine to be mostly outside of React Context
Adds subscriptions
Moves app state into folder and adds new app state util

* Moved cron to class component

* fix: EAS Build Fixes (#1099)

* remove testflight action

* fix eas

* oops

* Set to remote

* add platform checks

* fixes

* Expo is great

---------

Co-authored-by: Thierry <[email protected]>

* Only show changes that concern me

* feat: Android Variants (#984)

* feat: Android Variants

Added Android Variants
Moved folder structures
Removed Android build scripts used to update new variant info
Aligned eas.json profiles
Added new manifest and strings for Android resource merger

* missed file commit

* [create-pull-request] automated change (#1024)

Co-authored-by: alexrisch <[email protected]>

* feat: more design system stuff (#1006)

* wip

* more color fix

* fix hstack file name

* fix hstack file name

* fix hstack file name

* fix types + fix button + add more theme stuff

* fix button

* more fixes

* fix snapshots

* wip

* bottom sheet wip

* fix button component and refactor bottom sheet into multiple files

* more bottom sheet fixes

* clean up

* fix

* remove bottom sheet example stuff

* Rolled-up reactions (#1037)

* Always show reactions outside of the message bubble

No matter which content type it is

* useMemo on useStyles

* Revert "useMemo on useStyles"

This reverts commit 93657c4.

* Use app theme and start implementing values in styles

* WIP Implement new styling and colors to reaction bubbles

* Update reactors container outer margin

* Remove avatars in reaction bubbles; apply new design system for styling; use alias to import the theme

* Add `borderWidth` to theme

* Use border radius and border width from theme

* Implement rolled up reactions

* Move const

* Show top 3 reactions

* Put comment back in

* Change border color to match the background for user's own reactions

* Change chat background to theme `colors.background.surface`

* Set new background to `surface` also in App, Chat, and Input

* Remove the export default, put the memo inline with the component

* More design system implementation

- Replace `<View>` with `HStack` and `VStack` components
- Use the `Text` from the design-system not from `react-native`

* feat: TextField design system (#1074)

* add TextField and fix IconButton

* delete old button

* feat: Pressable Group Updates

Added handling when pressing a display name in the group updated messages

* Add Tests

* Correct styles on pressables

* Update pressable style

* update to design system

Fixed tsconfig
Added util to create text styles
Updated Chat Group Updated message to match design system
Added ParsedText component

* fix tests

* recs for cleaner (#1012)

* Update to follow design system

* fix icon button styling (#1076)

* fix: Xmtp Engine Rerenders, Race Conditions, Crashes  (#1036)

* fix: Xmtp Engine Rerenders, Race Conditions, Crashes

Refactored Xmtp Engine to be mostly outside of React Context
Adds subscriptions
Moves app state into folder and adds new app state util

* Moved cron to class component

* fix: EAS Build Fixes (#1099)

* remove testflight action

* fix eas

* oops

* Set to remote

* add platform checks

* fixes

* Expo is great

---------

Co-authored-by: Thierry <[email protected]>

* Feature: Navigation Refactor (#1025)

navigation refactor

* feat: remove web stuff (#1102)

remove web stuff

* rebase 2.0.8 (#1105)

* fix: Sync Account on Add (#1104)

* fix: Sync Account on Add

Added subscription for accounts store

* Safety

* fix: Run Android profile (#1107)

* [create-pull-request] automated change (#1106)

Co-authored-by: alexrisch <[email protected]>

* fix open conversation

* [create-pull-request] automated change (#1110)

Co-authored-by: thierryskoda <[email protected]>

* [create-pull-request] automated change (#1115)

Co-authored-by: alexrisch <[email protected]>

* Remove duplicated component

* Add missing tx preview component

* Fix snapshot

* Fix tests

* Comments from PR + fix tx frame success

* move default chain to its own file

* move default chain to its own file

---------

Co-authored-by: Saul Carlin <[email protected]>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: nmalzieu <[email protected]>
Co-authored-by: Alex Risch <[email protected]>
Co-authored-by: Alex Risch <[email protected]>
Co-authored-by: alexrisch <[email protected]>
Co-authored-by: Thierry Skoda <[email protected]>
Co-authored-by: Thierry <[email protected]>
Co-authored-by: Louis Rouffineau <[email protected]>
Co-authored-by: thierryskoda <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexrisch alexrisch alexrisch approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@thierryskoda @alexrisch