-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Group deletion flow is incomplete #315
Comments
Was the group declined, blocked, or deleted? The option to delete a chat is a Converse-specific feature that saves the deletion in the Converse backend. The deletion of a chat is not broadcasted to the protocol, only allowed/blocked peers are. Should we remove the "delete" option from the Converse backend? This might have a side effect where deleted conversations might appear again for some users. Mitigation: write a migration that blocks the peers from deleted chats on the protocol level. |
For 1:1 chats, the consent is on the peer level, vs. delete is on the conversation level and only on Converse's backend.
|
Following the daily, we opted to:
|
@lourou @nmalzieu @nplasterer During yesterday's discussion I was caught up by the technical details and whiffed the real product question here about the user expectation when "trashing" a group conversation. Given these things:
...I don't think we should be using either "block" or "delete" to describe our destructive action. Instead, until "Delete" and "Leave" can actually be supported, I think "Remove"/"Undo Remove" would be best. It aligns with the user's intent to "get this out of my inbox", leaves room for less permanence than "delete", and doesn't have a preexisting association like "block". |
I like the reasoning here. Sounds good to me. |
I agree! I will update the wording accordingly and make some adjustments for the removed chats view on iPad and web, as it uses a split screen instead of a single screen on iOS and Android. |
@saulmc Implementation done with "Remove/Restore" wording for consistency. See attached image. Note: "View and Restore" presents navigation challenges:
Need to balance user understanding, consistent navigation, and smooth UX. Thoughts on best approach? |
I think navigating back to main or requests (depending on consent) is actually expected here. Once I've restored the conversation, back should take me to wherever the conversation was restored "to". |
From Caroline:
We need to unblock this by answering #220 Undelete a group
My MVP proposal here is:
The text was updated successfully, but these errors were encountered: