Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update django.po #84

Merged
merged 3 commits into from
Mar 27, 2018
Merged

Update django.po #84

merged 3 commits into from
Mar 27, 2018

Conversation

tommybeck
Copy link
Contributor

I've reviewed English language original texts upon Manu's email request of 20 March

@codecov-io
Copy link

codecov-io commented Mar 26, 2018

Codecov Report

Merging #84 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #84   +/-   ##
=======================================
  Coverage   49.95%   49.95%           
=======================================
  Files          46       46           
  Lines        1105     1105           
=======================================
  Hits          552      552           
  Misses        553      553

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 44a5d69...e9e3a6a. Read the comment docs.

Copy link
Contributor

@ebreton ebreton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Peux-tu stp utiliser les msgstr plutôt que les msgid ? (cf commentaire ci-dessous 😄

@@ -56,7 +56,7 @@ msgid "detailed with abstract"
msgstr ""

#: infoscience_exports/exports/options_notices.py:12
msgid "Journal Articles"
msgid "Press Articles"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yo @tommybeck ! Bienvenu dans le monde fabuleux des PRs :)

En ce qui concerne les traductions, tu peux les faire dans le msgstr.

Le msgid est la clef du dictionnaire, utilisée dans le code. Donc si tu la change ici, l'appel dans le code devient "orphelin", et la prochaine fois qu'on génère les fichiers, la version du code va reprendre sa place ici.

A moins de changer le code bien sûr, dans le fichier mentionné au-dessus (infoscience_exports/exports/options_notices.py:12), mais je ne te recommande pas cette solution, qui peut avoir des effets de bords à d'autres endroits dans le code ...

@ebreton ebreton merged commit 80edc20 into master Mar 27, 2018
@ebreton ebreton deleted the tommybeck-revue-originaux-anglais branch March 27, 2018 14:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants