Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Better display of doc_types #80

Merged
merged 2 commits into from
Mar 22, 2018
Merged

Better display of doc_types #80

merged 2 commits into from
Mar 22, 2018

Conversation

dragonleman
Copy link
Contributor

No description provided.

@dragonleman dragonleman requested a review from ebreton March 22, 2018 12:12
ebreton
ebreton suggested changes Mar 22, 2018
View reviewed changes
Copy link
Contributor

@ebreton ebreton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

travail d'orfèvre sur les points et les virgules 🙇

Juste une remarque sur les CSS...

infoscience_exports/exports/static/css/export.css Outdated
@@ -178,12 +178,12 @@
padding-left: 0px;
}

.infoscience_record .infoscience_links {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

la classe est toujours présente dans les templates HTML... c'est normal que tu la supprimes ?

@dragonleman
Copy link
Contributor Author

Houps. Je devais faire 2 fois le copié-coller, pas une seule fois. Merci pour l'avoir noté.

@dragonleman dragonleman merged commit c44e879 into master Mar 22, 2018
@dragonleman dragonleman deleted the check-doc_types branch March 22, 2018 14:23
ebreton pushed a commit that referenced this pull request Mar 23, 2018
Merge branch 'master' into added-codecov
ced7d51 
* master:
  Better display of doc_types (#80)
  Fix loggout process on dev
  activated detailed forms + added summary (#78)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ebreton ebreton ebreton requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dragonleman @ebreton