renamed doc_types in template short #73
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ebreton
reviewed
Mar 21, 2018
There was a problem hiding this comment.
Comme ça risque de se reproduire, ca serait bien d'avoir un moyen de controle...
idéalement des tests automatiques, mais je pense qu'il faudra faire ça dans une autre PR. Ou bien on définit des constantes pour les clefs du dictionnaire DOC_TYPE_ORDERED ?
(et on les réutilise dans les templates)
|
Je préférerais aussi avoir des constantes pour les clefs de DOC_TYPE_ORDERED. Dans ce cas, soit TIND met aussi des clefs sur le champ 336__a, soit je compare la traduction en anglais de la constante, mais alors cela ne changerait rien par rapport à la solution ici ... |
|
On laisse comme ça! j'ai créer une issue liée à cette PR pour qu'on pense à améliorer ça. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.