Add url fetcher from parameter when creating an export #69
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dragonleman
reviewed
Mar 20, 2018
| @@ -241,7 +241,8 @@ def import_marc21xml(url, can_display_pending_publications): | |||
| result = [] | |||
|
|
|||
| o = urlparse(url) | |||
| if o.netloc not in settings.ALLOWED_HOSTS: | |||
| if not '*' in settings.ALLOWED_HOSTS and \ | |||
There was a problem hiding this comment.
Oublié de revenir en arrière ?
There was a problem hiding this comment.
je suis obligé de forcer ce test, car pour selenium je ne connais pas l'ip en avance qu'il lance, ce qui m'oblige à overrider ce settings (à voir https://github.com/epfl-idevelop/infoscience-exports/blob/bf739b95900c7e389aa6845e3a6a00835c16e4c8/infoscience_exports/exports/test/test_selenium.py#L14 )
dragonleman
approved these changes
Mar 20, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Lire le test, on peut voir que toute l'url est "unquotée". Cela fonctionne aussi, c'est juste qu'il y aura deux formats d'url sauvé dans la BD, un unquoté et un quoté, selon l'origine de la création de l'export.
Tenez-moi au courant si ce n'est pas acceptable.