Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve allowed host config #51

Merged
merged 4 commits into from
Mar 14, 2018
Merged

Improve allowed host config #51

merged 4 commits into from
Mar 14, 2018

Conversation

ebreton
Copy link
Contributor

@ebreton ebreton commented Mar 14, 2018

  • allow to configure multiple ALLOWED_HOST from environement variables

⚠️ this PR requires the modification of variable environment

in production

  • replace ALLOWED_HOST=infoscience.epfl.ch with ALLOWED_HOSTS=infoscience.epfl.ch (there is a final S now on ALLOWED_HOSTS)

in QA

  • replace ALLOWED_HOST=infoscience-exports-test.tind.io with ALLOWED_HOSTS=infoscience-exports-test.tind.io,epfl.tind.io

in DEV

  • replace ALLOWED_HOST with ALLOWED_HOSTS
  • add SERVER_HOST=${ALLOWED_HOSTS} if you have only one domain in your ALLOWED_HOSTS, or SERVER_HOST=your-host otherwise
  • replace SITE_URL=https://${ALLOWED_HOST}:${DEV_PORT}${SITE_PATH} with SITE_URL=https://${SERVER_HOST}:${DEV_PORT}${SITE_PATH}

@ebreton
Copy link
Contributor Author

ebreton commented Mar 14, 2018

Merging after agreement with Audun

@ebreton ebreton merged commit a980f05 into master Mar 14, 2018
@ebreton ebreton deleted the improve-ALLOWED_HOST-config branch March 17, 2018 10:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant