Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FullText: only one link to redirect to a pdf or a directory with several media #47

Merged
merged 2 commits into from
Mar 12, 2018

Conversation

dragonleman
Copy link
Contributor

No description provided.

Copy link
Contributor

@ebreton ebreton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

une suggestion de refactoring.

tout bon pour le reste ! ⭐️

o_first = urlparse(fulltexts[0])
path_first = dirname(o_first.path)
is_same_path = True
for ft in fulltexts:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tu parcours une seconde fois les résultats... pas possible de préparer le terrain dans la première boucle ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

c'était simplement pour une raison de clarté.

@dragonleman dragonleman merged commit 2a189ee into master Mar 12, 2018
@dragonleman dragonleman deleted the fulltext branch March 12, 2018 15:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants