Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix using app url for export source #110

Merged
merged 1 commit into from
May 4, 2018
Merged

Conversation

jdelasoie
Copy link
Member

No description provided.

@jdelasoie jdelasoie requested review from ebreton and dragonleman May 4, 2018 08:24
@codecov-io
Copy link

codecov-io commented May 4, 2018

Codecov Report

Merging #110 into master will decrease coverage by 0.03%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #110      +/-   ##
==========================================
- Coverage   26.41%   26.38%   -0.04%     
==========================================
  Files          62       62              
  Lines        2256     2259       +3     
==========================================
  Hits          596      596              
- Misses       1660     1663       +3
Impacted Files Coverage Δ
infoscience_exports/exports/marc21xml.py 33.02% <0%> (-0.47%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4924b96...f8fc11e. Read the comment docs.

Copy link
Contributor

@ebreton ebreton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

c'est tout bon de le mettre au moment du traitement. Est ce que tu peux aussi rajouter un validateur au niveau du formulaire, histoire que les utilistateurs soient prévenus

@jdelasoie
Copy link
Member Author

C'est que la personne voit le message d'erreur quand il clique sur preview. je suis d'accord avec toi sur le fond, mais à ce moment-là ce n'est plus un quick fix, mais un fix. On le fait après avoir éteins ce feu ?

@jdelasoie jdelasoie merged commit c2239d3 into master May 4, 2018
@jdelasoie jdelasoie deleted the fix-self-referencing-url branch May 4, 2018 09:07
@ebreton
Copy link
Contributor

ebreton commented May 4, 2018

ok ça joue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants