Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Callback.failed #1619

Merged
merged 1 commit into from
Dec 13, 2024
Merged

Conversation

mbovel
Copy link
Collaborator

@mbovel mbovel commented Dec 10, 2024

Callback.failed is always a no-op, and is not called from anywhere. This PR removes it.

@mbovel mbovel force-pushed the mb/remove-callback-failed branch from 675bdb2 to 1c7e30e Compare December 11, 2024 18:49
@vkuncak vkuncak force-pushed the mb/remove-callback-failed branch from 1c7e30e to 7fb91ac Compare December 13, 2024 16:50
@vkuncak vkuncak assigned mario-bucev and unassigned mario-bucev Dec 13, 2024
@vkuncak vkuncak merged commit d1e4909 into epfl-lara:main Dec 13, 2024
3 checks passed
@mbovel mbovel deleted the mb/remove-callback-failed branch December 13, 2024 21:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants