AntiAliasing: restore var binding in mapApplication #1509
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR #1507 made some changes to
mapApplication
, and one I made by negligence (in the diff line) turned out to unveil an issue in theLet
case handling ofAntiAliasing
(line in question).Here, we compute the targets of the transformed binding. If this binding happens to contain a function call, the returned targets may be invalid because
getTargets
works on functions prior to theAntiAliasing
function purification, not after (as it's done here).The reason this issue did not arise before is the
var
introduced bymapApplication
prevented target computation, which ultimately resulted in rejection.This PR simply reverts the changed lines but the underlying issue is still here (though it cannot be triggered). To properly fix this, we would need to distinguish pre/post transformation
getTargets
computation, which would require significant changes toEffectsAnalyzer
.