Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove duplicated default value doc #1502

Merged
merged 1 commit into from
Feb 27, 2024
Merged

Remove duplicated default value doc #1502

merged 1 commit into from
Feb 27, 2024

Conversation

shilangyu
Copy link
Contributor

Before this change the information about the default value was duplicated in the docs of --help:

[  Info  ] --strict-arithmetic[=true|false]                 Check arithmetic operations for unintended behavior and overflows (default: true) (default: true)

The default value notice is added later, outside of the description string.

@CLAassistant
Copy link

CLAassistant commented Feb 16, 2024

CLA assistant check
All committers have signed the CLA.

@mario-bucev
Copy link
Collaborator

Thanks for the catch! For some reason the CI is not running and I don't have the GH rights to merge a PR without it running 🤦‍♂️ I'll see if someone can do it.

@samarion
Copy link
Member

There's an allowlist of users for which the larabot CI will run (somewhere int he larabot config). And it seems we've disabled force-push from GH completely, even for admins :)

@vkuncak I'll re-enable force push for administrators so we can merge this PR.

@samarion samarion merged commit f37629a into epfl-lara:main Feb 27, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants