Applying some type widening in ReturnElimination to avoid triggering AdtSpecialization
#1466
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vkuncak
reviewed
Nov 1, 2023
| @@ -495,6 +497,19 @@ class ReturnElimination(override val s: Trees, override val t: Trees) | |||
| (res, fnSum) | |||
| } | |||
|
|
|||
| // Recursively widen class types to their top ancestor, and strips sigma, pi and refinement types. | |||
| // This used to type the control flow type parameters in order to avoid triggering AdtSpecialization | |||
There was a problem hiding this comment.
whoops, thanks for catching that!
mario-bucev
force-pushed
the
widening-returnelimination
branch
from
90b9a4a to
db6fac3
Compare
…AdtSpecialization
mario-bucev
force-pushed
the
widening-returnelimination
branch
from
db6fac3 to
d9b3471
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For instance, the provided tests in
RefnChecksWithReturn.scalawould unexpectedly generate "refinement checks for subtyping" which may result in being invalid due to #1463.