Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes for AllowOverlap and internal changes in 1.89.7 #486

Merged
merged 2 commits into from
Jun 28, 2023

Conversation

ocornut
Copy link
Collaborator

@ocornut ocornut commented Jun 28, 2023

  • Removed misleading/unnecessary use of ImGuiButtonFlags_AllowItemOverlap in BeginSubplots(). (Subplots #203)
  • Fixes for 1.89.7 renaming + new ImGuiButtonFlags_AllowOverlap behavior handled by ButtonBehavior() fixes other items from hovering while dragging plot.

Added a bit of ifdef machinery so changes will also work with older versions of ImGui.

ocornut added 2 commits June 26, 2023 18:25
…ap in BeginSubplots(). (epezent#203)

Likely this was pulled from SplitterBehavior(), where it made senses but only given the possibility user would call SetItemAllowOverlap() after.
AFAIK after debugging the code I _think_ this has no meaningful side-effect. Also removed same thing in Tables code in core lib.
Flag added in epezent@4a1ee88.
… by ButtonBehavior() fixes other items from hovering while dragging plot.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant