Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Error if KeycloakClient secret is deleted before it #70

Merged
merged 1 commit into from
Jun 25, 2024

Conversation

zmotso
Copy link
Contributor

@zmotso zmotso commented Jun 25, 2024

Pull Request Template

Description

Moved the deletion process of the KeycloakClient before any logic that requires client secrets.
This will help avoid errors if the KeycloakClient secret is removed before it and the deletion process gets stuck.

Fixes #62

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality not to work as expected)

How Has This Been Tested?

Manually.

Checklist:

  • I have performed a self-review of my code
  • I have commented on my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Pull Request contains one commit. I squash my commits

Moved the deletion process of the KeycloakClient
before any logic that requires client secrets.
This will help avoid errors if the KeycloakClient secret
is removed before it and the deletion process gets stuck.
@zmotso zmotso self-assigned this Jun 25, 2024
@zmotso zmotso requested a review from a team as a code owner June 25, 2024 13:10
@zmotso zmotso added the bug Something isn't working label Jun 25, 2024
@MykolaMarusenko MykolaMarusenko merged commit 4882fc4 into master Jun 25, 2024
11 checks passed
@MykolaMarusenko MykolaMarusenko deleted the i/62 branch June 25, 2024 13:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Error if secret created and owned by keycloakclient is deleted before it
2 participants