Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Boolean parameters with default values are always 'true' #108

Merged
merged 1 commit into from
Nov 6, 2024
Merged

Conversation

zmotso
Copy link
Contributor

@zmotso zmotso commented Nov 6, 2024

Pull Request Template

Description

Fixed behavior when boolean parameters with default values are always 'true'.

Fixes #56

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Enhancement (non-breaking change which improves an existing feature or documentation)
  • Breaking change (fix or feature that would cause existing functionality not to work as expected)

How Has This Been Tested?

  • Manual testing

Checklist:

  • I have performed a self-review of my code
  • I have commented on my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Pull Request contains one commit. I squash my commits.

@zmotso zmotso added the bug Something isn't working label Nov 6, 2024
@zmotso zmotso self-assigned this Nov 6, 2024
@zmotso zmotso requested a review from a team as a code owner November 6, 2024 10:47
@SergK SergK merged commit da5702d into master Nov 6, 2024
11 checks passed
@SergK SergK deleted the i/56 branch November 6, 2024 11:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Boolean parameters with value false are silently ignored
2 participants