Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Setting of the tool icon size #493

Closed
NShaforostov opened this issue Jul 4, 2019 · 1 comment
Closed

Setting of the tool icon size #493

NShaforostov opened this issue Jul 4, 2019 · 1 comment
Assignees
@rodichenko @AleksandrGorodetskii
Labels
kind/question Further information is requested priority/low Issues that can be implemented when there is no other work state/verify Issues that are already addressed and require validation sys/gui Issues related to the web gui
Milestone
v0.16

Comments

@NShaforostov
Copy link
Collaborator

Case 1

  1. Open system-level settings, select Preferences tab
  2. Set a new value into the misc.max.tool.icon.size.kb preference that is bigger than default 50 Kb, e.g. 200
  3. Save and close pop-up
  4. Open any tool, try to upload an icon with the size in the range from 50 to 200 Kb

Exp.: a new icon will be uploaded
Act.: the follow-up error appears: 2, a new icon isn't uploaded

Is it a normal behavior? If yes - probably, we should implement a warning or something else to restrict the input into the misc.max.tool.icon.size.kb preference?

Case 2

  1. Open system-level settings, select Preferences tab
  2. Set a new value into the misc.max.tool.icon.size.kb preference that is smaller than default 50 Kb, e.g. 30
  3. Save and close pop-up
  4. Open any tool, try to upload an icon with the size in the range from 30 to 50 Kb
  5. An error appears, e.g.:
    1

Can we make it a bit more graceful? For example: Uploaded icon is too large: 43,388 bytes. Only 30,000 bytes allowed or just in a style described above: Maximum file size is 30kb

Case 3

  1. Repeat steps 1-3 from Case 2
  2. Open any tool, try to upload an icon with the size more than 50 Kb

Exp.: an error in a style like in Case 2 appears
Act.: the follow-up error appears: 2

Probably, we should unify error messages for Case 2 and Case 3?
@NShaforostov NShaforostov added kind/question Further information is requested priority/low Issues that can be implemented when there is no other work sys/gui Issues related to the web gui labels Jul 4, 2019
@NShaforostov NShaforostov added this to the v0.17 milestone Jul 5, 2019
@rodichenko rodichenko added the state/underway Issues that are currently being solved/implemented label Jul 12, 2019
AleksandrGorodetskii added a commit to AleksandrGorodetskii/cloud-pipeline that referenced this issue Jul 12, 2019
@AleksandrGorodetskii
GUI ISSUE epam#493 fixed.
1ea279b 
Now we get 'maximumFileSize' from this.props.preferences.getPreferenceValue('misc.max.tool.icon.size.kb') instead from DEFAULT_VALUE = 50 in <Tool> component. And compare this value with image.size.
AleksandrGorodetskii added a commit to AleksandrGorodetskii/cloud-pipeline that referenced this issue Jul 16, 2019
@AleksandrGorodetskii
GUI ISSUE epam#493 fixed.
c69923e 
If getPreferenceValue from setting is possible, we get 'maximumFileSize' from this.props.preferences.getPreferenceValue('misc.max.tool.icon.size.kb') instead from DEFAULT_VALUE in <Tool> component. And compare this value with image.size.
AleksandrGorodetskii added a commit to AleksandrGorodetskii/cloud-pipeline that referenced this issue Jul 16, 2019
@AleksandrGorodetskii
Merge branch 'gui-issue-#493_Setting-of-the-tool-icon-size' of https:…
117265c 
…//github.com/AleksandrGorodetskii/cloud-pipeline into gui-issue-#493_Setting-of-the-tool-icon-size

GUI ISSUE epam#493 fixed.
If getPreferenceValue from setting is possible, we get 'maximumFileSize' from this.props.preferences.getPreferenceValue('misc.max.tool.icon.size.kb') instead from DEFAULT_VALUE in <Tool> component. And compare this value with image.size.
Merged
rodichenko pushed a commit that referenced this issue Jul 24, 2019
@AleksandrGorodetskii @rodichenko
Gui issue #493 setting of the tool icon size (#529)
0cc1a4d
@rodichenko rodichenko added state/verify Issues that are already addressed and require validation and removed state/underway Issues that are currently being solved/implemented labels Jul 24, 2019
@NShaforostov NShaforostov modified the milestones: v0.17, v0.16 Jul 25, 2019
@NShaforostov
Copy link
Collaborator Author

Verified. Fixed

evgeniimv pushed a commit to evgeniimv/cloud-pipeline that referenced this issue Oct 14, 2019
@AleksandrGorodetskii @rodichenko
Gui issue epam#493 setting of the tool icon size (epam#529)
4dfd0ff
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rodichenko rodichenko

@AleksandrGorodetskii AleksandrGorodetskii

Labels
kind/question Further information is requested priority/low Issues that can be implemented when there is no other work state/verify Issues that are already addressed and require validation sys/gui Issues related to the web gui
Projects
None yet
Milestone
v0.16
Development

No branches or pull requests
3 participants
@rodichenko @AleksandrGorodetskii @NShaforostov