Skip to content

Commit

Permalink
issue #3131 fix for cluster runs, when run cluster workers - calculat…
Browse files Browse the repository at this point in the history
…e configuration only ones and then just copy it
  • Loading branch information
SilinPavel committed Mar 31, 2023
1 parent 15954ad commit a145756
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 4 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -1284,9 +1284,10 @@ private void runClusterWorkers(PipelineRun run, PipelineStart runVO, String vers
PipelineConfiguration configuration) {
String parentId = Long.toString(run.getId());
Integer nodeCount = configuration.getNodeCount();
final PipelineConfiguration workerConfigurationTemplate = configurationManager.generateWorkerConfiguration(
parentId, runVO, configuration, false, true);
for (int i = 0; i < nodeCount; i++) {
final PipelineConfiguration workerConfiguration = configurationManager.generateWorkerConfiguration(
parentId, runVO, configuration, false, true);
final PipelineConfiguration workerConfiguration = workerConfigurationTemplate.clone();
launchPipeline(
workerConfiguration, pipeline, version, runVO.getInstanceType(), runVO.getConfigurationName(),
parentId, run.getId(), null, null, runVO.getRunSids(),
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -167,9 +167,10 @@ private List<PipelineRun> runConfigurationEntry(RunConfigurationEntry entry,
Pipeline pipeline = entry.getPipelineId() != null ? pipelineManager.load(entry.getPipelineId()) : null;
List<PipelineRun> result = new ArrayList<>();
log.debug("Launching total {} copies of entry {}", copies, entry.getName());
final PipelineConfiguration runConfigurationTemplate =
buildRunConfiguration(entry, configuration, clusterId, startNFS, startVO);
for (int i = 0; i < copies; i++) {
final PipelineConfiguration runConfiguration =
buildRunConfiguration(entry, configuration, clusterId, startNFS, startVO);
final PipelineConfiguration runConfiguration = runConfigurationTemplate.clone();
//only first node may be a NFS server
if (i != 0) {
runConfiguration.setCmdTemplate(WORKER_CMD_TEMPLATE);
Expand Down

0 comments on commit a145756

Please sign in to comment.