Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: span names #543

Merged
merged 1 commit into from
Oct 28, 2024
Merged

fix: span names #543

merged 1 commit into from
Oct 28, 2024

Conversation

alekseyvdovenko
Copy link
Contributor

@alekseyvdovenko alekseyvdovenko commented Oct 23, 2024 •
edited
Loading

Closes #542

@alekseyvdovenko alekseyvdovenko added the bug Something isn't working label Oct 23, 2024
@alekseyvdovenko alekseyvdovenko self-assigned this Oct 23, 2024
@alekseyvdovenko alekseyvdovenko linked an issue Oct 23, 2024 that may be closed by this pull request
Fix span names #542
Closed
@alekseyvdovenko alekseyvdovenko force-pushed the feat/issue-542 branch 2 times, most recently from 398a082 to 84b7edc Compare October 23, 2024 15:54
@alekseyvdovenko
Copy link
Contributor Author

alekseyvdovenko commented Oct 23, 2024 •
edited by ai-dial-actions
Loading

/deploy-review

Environment URL: https://chat-ai-dial-core-pr-543.nightly-test.deltixhub.io
E2E tests status: failed

@alekseyvdovenko
Copy link
Contributor Author

alekseyvdovenko commented Oct 24, 2024 •
edited by ai-dial-actions
Loading

/deploy-review

Environment URL: https://chat-ai-dial-core-pr-543.nightly-test.deltixhub.io
E2E tests status: failed

akurnosau
akurnosau previously approved these changes Oct 28, 2024
View reviewed changes
@alekseyvdovenko alekseyvdovenko merged commit 3b35864 into development Oct 28, 2024
7 checks passed
@alekseyvdovenko alekseyvdovenko deleted the feat/issue-542 branch October 29, 2024 10:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@astsiapanay astsiapanay astsiapanay approved these changes

@akurnosau akurnosau akurnosau left review comments

@kkazakevich kkazakevich Awaiting requested review from kkazakevich

@artsiomkorzun artsiomkorzun Awaiting requested review from artsiomkorzun artsiomkorzun is a code owner

Assignees

@alekseyvdovenko alekseyvdovenko

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix span names
3 participants
@alekseyvdovenko @astsiapanay @akurnosau