Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change authentication workflow #60

Closed
avavilau opened this issue Nov 27, 2023 · 1 comment
Closed

Change authentication workflow #60

avavilau opened this issue Nov 27, 2023 · 1 comment
Assignees
Labels
enhancement New feature or request

Comments

@avavilau
Copy link
Contributor

  • Core must only support authorization via key or token, not both
  • Application must receive tokens with restricted to its client_id
@avavilau avavilau added the enhancement New feature or request label Nov 27, 2023
@avavilau avavilau added this to AI DIAL Nov 27, 2023
@astsiapanay
Copy link
Collaborator

Some clarifications about the task:

[4:09 PM] Aliaksandr Stsiapanay
Questions
1.
Supposing just token comes in the request
We always validate user token in this case anyway. (verify signature)
As a result the field Key.userAuth is no longer needed.
2. API key
User roles are empty in this case.
3. User token
We just validate user roles but we don't validate limits on tokens per model because API key is missed.
Supposing user have unlimited access.

Is that correct?
[4:14 PM] Aliaksei Vavilau
Correct

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants