Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix crash when removing the sole table row #2680

Merged
merged 1 commit into from
Dec 4, 2024

Conversation

cpoftea
Copy link
Contributor

@cpoftea cpoftea commented Dec 3, 2024

Description:

Fixes app crashes when deleting sole table row

Issue link:

Closes #2673

QA notes:

It is @udecode/plate-table bug. Fixed at v40.0.0 (plate-table changelog)
I added a temporary fix to prevent the error when removing the sole row in a table and left reference within a comment, mentioning that fix can be removed after upgrade to corresponding version.

`@udecode/plate-table` bug. Fixed at `v40.0.0`.
Added a temporary fix to prevent the error when removing the sole row in a table.
Copy link

github-actions bot commented Dec 3, 2024

Generated by: track-bundle-size
Generated at: Tue, 03 Dec 2024 23:53:42 GMT
Bundle size diff (in kBytes). Not gzipped. Both CSS & JS included.
Baseline: v5.11.0 (2024-11-22)
CI Status: ok

Module Baseline Size
(v5.11.0)
Size Diff Within
Threshold
Threshold
(min - max)
templateApp 767.47 773.36 +5.89
js:+0.5
css:+5.39
🆗 690.72 - 844.21
@epam/app 5631.71 5652.91 +21.2
js:+13.37
css:+7.83
🆗 5068.53 - 6194.88
@epam/draft-rte 53.78 53.83 +0.04
js:+0
css:+0.03
🆗 48.41 - 59.17
@epam/electric 4.58 4.6 +0.01
js:+0
css:+0.01
🆗 4.12 - 5.04
@epam/promo 55.24 55.46 +0.23
js:0
css:+0.23
🆗 49.71 - 60.76
@epam/uui-extra 0.21 0.21 0
js:0
css:0
🆗 0.19 - 0.23
@epam/loveship 91.19 91.41 +0.22
js:0
css:+0.22
🆗 82.07 - 100.31
@epam/uui-components 264.19 268.43 +4.24
js:+4.11
css:+0.13
🆗 237.77 - 290.61
@epam/uui-core 338.13 337.95 -0.18
js:-0.18
css:0
🆗 304.32 - 371.94
@epam/uui-db 44.7 44.7 0
js:0
css:0
🆗 40.23 - 49.17
@epam/uui-docs 176.28 181.23 +4.95
js:+4.95
css:0
🆗 158.65 - 193.91
@epam/uui-editor 184.43 185 +0.57
js:+0.58
css:-0.01
🆗 165.98 - 202.87
@epam/uui-timeline 80.98 82.08 +1.1
js:+1.15
css:-0.05
🆗 72.88 - 89.08
@epam/uui 611.83 624.26 +12.44
js:+6.4
css:+6.04
🆗 550.64 - 673.01
new sizes (raw)

To set the sizes as a new baseline, you can copy/paste next content to the uui-build/config/bundleSizeBaseLine.json and commit the file.

{
  "version": "5.11.1-rc.0",
  "timestamp": "2024-12-03",
  "sizes": {
    "templateApp": {
      "css": 308646,
      "js": 483273
    },
    "@epam/app": {
      "css": 739375,
      "js": 5049196
    },
    "@epam/draft-rte": {
      "css": 9817,
      "js": 45297
    },
    "@epam/electric": {
      "css": 2289,
      "js": 2417
    },
    "@epam/promo": {
      "css": 47374,
      "js": 9424
    },
    "@epam/uui-extra": {
      "css": 0,
      "js": 213
    },
    "@epam/loveship": {
      "css": 53345,
      "js": 40264
    },
    "@epam/uui-components": {
      "css": 22645,
      "js": 252232
    },
    "@epam/uui-core": {
      "css": 0,
      "js": 346063
    },
    "@epam/uui-db": {
      "css": 0,
      "js": 45769
    },
    "@epam/uui-docs": {
      "css": 2445,
      "js": 183137
    },
    "@epam/uui-editor": {
      "css": 12736,
      "js": 176697
    },
    "@epam/uui-timeline": {
      "css": 2199,
      "js": 81849
    },
    "@epam/uui": {
      "css": 286520,
      "js": 352728
    }
  }
}

Generated by: generate-components-api
CI Status: ok

Total amount of exported types/props without JSDoc comments

Amount
Types 301 (+0) 🆗
Props 233 (+0) 🆗

@AlekseyManetov AlekseyManetov merged commit 183a3fd into epam:develop Dec 4, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants