Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Alert]: Added support for size theming #2643

Merged
merged 8 commits into from
Nov 26, 2024

Conversation

siarhei-epam
Copy link
Collaborator

@siarhei-epam siarhei-epam commented Nov 16, 2024

Description:

[Alert]: Added support for size theming
Updated 'stylelint' rule length-zero-no-unit to avoid problems with 'css' calculations. Added ignore units for zero length in custom properties. See link.

Issue link:

#2620

QA notes:

Some attributes are different on design & develop to avoid breaking changes.

@siarhei-epam siarhei-epam self-assigned this Nov 16, 2024
Copy link

github-actions bot commented Nov 16, 2024

Generated by: track-bundle-size
Generated at: Tue, 26 Nov 2024 17:39:56 GMT
Bundle size diff (in kBytes). Not gzipped. Both CSS & JS included.
Baseline: v5.11.0 (2024-11-22)
CI Status: ok

Module Baseline Size
(v5.11.0)
Size Diff Within
Threshold
Threshold
(min - max)
templateApp 767.47 773.45 +5.98
js:+0.59
css:+5.39
🆗 690.72 - 844.21
@epam/app 5631.71 5651.01 +19.31
js:+11.47
css:+7.84
🆗 5068.53 - 6194.88
@epam/draft-rte 53.78 53.78 0
js:0
css:0
🆗 48.41 - 59.17
@epam/electric 4.58 4.58 0
js:0
css:0
🆗 4.12 - 5.04
@epam/promo 55.24 55.46 +0.23
js:0
css:+0.23
🆗 49.71 - 60.76
@epam/uui-extra 0.21 0.21 0
js:0
css:0
🆗 0.19 - 0.23
@epam/loveship 91.19 91.42 +0.23
js:0
css:+0.23
🆗 82.07 - 100.31
@epam/uui-components 264.19 268.46 +4.26
js:+4.11
css:+0.16
🆗 237.77 - 290.61
@epam/uui-core 338.13 338.48 +0.35
js:+0.35
css:0
🆗 304.32 - 371.94
@epam/uui-db 44.7 44.7 0
js:0
css:0
🆗 40.23 - 49.17
@epam/uui-docs 176.28 176.28 0
js:0
css:0
🆗 158.65 - 193.91
@epam/uui-editor 184.43 184.24 -0.19
js:-0.19
css:0
🆗 165.98 - 202.87
@epam/uui-timeline 80.98 82.08 +1.1
js:+1.16
css:-0.05
🆗 72.88 - 89.08
@epam/uui 611.83 624.24 +12.42
js:+6.4
css:+6.01
🆗 550.64 - 673.01
new sizes (raw)

To set the sizes as a new baseline, you can copy/paste next content to the uui-build/config/bundleSizeBaseLine.json and commit the file.

{
  "version": "5.11.0",
  "timestamp": "2024-11-26",
  "sizes": {
    "templateApp": {
      "css": 308643,
      "js": 483371
    },
    "@epam/app": {
      "css": 739384,
      "js": 5047250
    },
    "@epam/draft-rte": {
      "css": 9782,
      "js": 45296
    },
    "@epam/electric": {
      "css": 2275,
      "js": 2416
    },
    "@epam/promo": {
      "css": 47374,
      "js": 9424
    },
    "@epam/uui-extra": {
      "css": 0,
      "js": 213
    },
    "@epam/loveship": {
      "css": 53354,
      "js": 40263
    },
    "@epam/uui-components": {
      "css": 22670,
      "js": 252229
    },
    "@epam/uui-core": {
      "css": 0,
      "js": 346604
    },
    "@epam/uui-db": {
      "css": 0,
      "js": 45769
    },
    "@epam/uui-docs": {
      "css": 2447,
      "js": 178066
    },
    "@epam/uui-editor": {
      "css": 12746,
      "js": 175908
    },
    "@epam/uui-timeline": {
      "css": 2201,
      "js": 81852
    },
    "@epam/uui": {
      "css": 286499,
      "js": 352728
    }
  }
}

Generated by: generate-components-api
CI Status: ok

Total amount of exported types/props without JSDoc comments

Amount
Types 301 (+0) 🆗
Props 233 (+0) 🆗

@AlekseyManetov AlekseyManetov merged commit dd965c3 into develop Nov 26, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants