Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Rating]: added to uui package #2624

Merged
merged 8 commits into from
Nov 14, 2024
Merged

Conversation

siarhei-epam
Copy link
Collaborator

@siarhei-epam siarhei-epam commented Nov 13, 2024

Description:

[Rating]: added to @epam/uui, removed independent components from 'skins', now reexport from @epam/uui is used, removed redundant(filledStarIcon, emptyStarIcon, renderRating, from, to) props for all packages, changed colors for empty & disabled stars for 'Promo' & 'Loveship' skins according design

QA notes:

Design - https://www.figma.com/design/M5Njgc6SQJ3TPUccp5XHQx/UUI-Components?node-id=54912-553&t=nenQXvyb4O5Sl7k3-4

Issue link: #2629

@siarhei-epam siarhei-epam self-assigned this Nov 13, 2024
Copy link

github-actions bot commented Nov 13, 2024

Generated by: track-bundle-size
Generated at: Thu, 14 Nov 2024 15:29:28 GMT
Bundle size diff (in kBytes). Not gzipped. Both CSS & JS included.
Baseline: v5.10.0 (2024-10-15)
CI Status: ok

Module Baseline Size
(v5.10.0)
Size Diff Within
Threshold
Threshold
(min - max)
templateApp 760.53 767.81 +7.27
js:+3.93
css:+3.34
🆗 684.48 - 836.59
@epam/app 5578.86 5635.03 +56.16
js:+4.67
css:+51.49
🆗 5020.98 - 6136.75
@epam/draft-rte 53.77 53.77 +0.01
js:+0
css:+0
🆗 48.39 - 59.15
@epam/electric 4.57 4.6 +0.02
js:+0.01
css:+0.01
🆗 4.12 - 5.03
@epam/promo 57.15 55.26 -1.89
js:-1.44
css:-0.45
🆗 51.44 - 62.87
@epam/uui-extra 0.21 0.21 0
js:0
css:0
🆗 0.19 - 0.23
@epam/loveship 93.74 91.23 -2.51
js:-2.22
css:-0.29
🆗 84.36 - 103.11
@epam/uui-components 263.21 264.16 +0.95
js:+0.95
css:0
🆗 236.89 - 289.54
@epam/uui-core 337.45 338.14 +0.69
js:+0.69
css:0
🆗 303.7 - 371.19
@epam/uui-db 44.7 44.7 0
js:0
css:0
🆗 40.23 - 49.17
@epam/uui-docs 207.12 207.12 0
js:0
css:0
🆗 186.41 - 227.83
@epam/uui-editor 183.61 184.17 +0.56
js:+0.54
css:+0.01
🆗 165.25 - 201.97
@epam/uui-timeline 79.51 80.98 +1.46
js:+1.47
css:0
🆗 71.56 - 87.46
@epam/uui 606.81 612.11 +5.29
js:+2.51
css:+2.78
🆗 546.13 - 667.49
new sizes (raw)

To set the sizes as a new baseline, you can copy/paste next content to the uui-build/config/bundleSizeBaseLine.json and commit the file.

{
  "version": "5.11.0-rc.0",
  "timestamp": "2024-11-14",
  "sizes": {
    "templateApp": {
      "css": 303462,
      "js": 482772
    },
    "@epam/app": {
      "css": 731696,
      "js": 5038567
    },
    "@epam/draft-rte": {
      "css": 9773,
      "js": 45296
    },
    "@epam/electric": {
      "css": 2289,
      "js": 2417
    },
    "@epam/promo": {
      "css": 47166,
      "js": 9424
    },
    "@epam/uui-extra": {
      "css": 0,
      "js": 213
    },
    "@epam/loveship": {
      "css": 53143,
      "js": 40269
    },
    "@epam/uui-components": {
      "css": 22527,
      "js": 247972
    },
    "@epam/uui-core": {
      "css": 0,
      "js": 346251
    },
    "@epam/uui-db": {
      "css": 0,
      "js": 45769
    },
    "@epam/uui-docs": {
      "css": 2448,
      "js": 209640
    },
    "@epam/uui-editor": {
      "css": 12748,
      "js": 175841
    },
    "@epam/uui-timeline": {
      "css": 2254,
      "js": 80667
    },
    "@epam/uui": {
      "css": 280623,
      "js": 346169
    }
  }
}

Generated by: generate-components-api
CI Status: ok

Total amount of exported types/props without JSDoc comments

Amount
Types 301 (+1) ⚠️🆗
Props 233 (+0) 🆗
New missing comments
NOTE: It's either a new exported types/props without JSDoc, or it's an existing code from which you deleted the JSDoc comments.
Types:
- @epam/uui:RatingModsOverride
Props:
- <empty>

@AlekseyManetov AlekseyManetov merged commit f7fe841 into develop Nov 14, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants