Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DataTable]: reworked isAwaysVisible column configuration prop and isLocked prop #2539

Merged
merged 2 commits into from
Oct 9, 2024

Conversation

AlekseyManetov
Copy link
Collaborator

Issue link(if exists): #2527

Description:

  * [Breaking change]: reworked `isAwaysVisible` column configuration prop. Now it's not make column fixed by default and doesn't forbid to unpin or reorder, it's only disallow to hide this column from table. If you need previous behavior, please use `isLocked` prop.
  * Added `isLocked` prop for column configuration. If `true` value provided, makes this column locked, which means that you can't hide, unpin or reorder this column. This column should always be pined.
@AlekseyManetov AlekseyManetov changed the title [DataTable]: [DataTable]: reworked isAwaysVisible column configuration prop and isLocked prop Oct 9, 2024
Copy link

github-actions bot commented Oct 9, 2024

Generated by: track-bundle-size
Generated at: Wed, 09 Oct 2024 15:46:36 GMT
Bundle size diff (in kBytes). Not gzipped. Both CSS & JS included.
Baseline: v5.8.4 (2024-07-30)
CI Status: ok

Module Baseline Size
(v5.8.4)
Size Diff Within
Threshold
Threshold
(min - max)
templateApp 755.39 761.2 +5.81
js:-1.82
css:+7.63
🆗 679.85 - 830.92
@epam/app 6552.38 6593.07 +40.68
js:+19.23
css:+21.45
🆗 5897.14 - 7207.62
@epam/draft-rte 53.77 53.79 +0.01
js:+0.01
css:+0.01
🆗 48.39 - 59.15
@epam/electric 4.57 4.59 +0.01
js:0
css:+0.01
🆗 4.12 - 5.03
@epam/promo 55.66 57.14 +1.48
js:-0.04
css:+1.52
🆗 50.1 - 61.23
@epam/uui-extra 0.21 0.21 0
js:0
css:0
🆗 0.19 - 0.23
@epam/loveship 92.08 93.77 +1.68
js:+0
css:+1.68
🆗 82.88 - 101.3
@epam/uui-components 260.74 263.15 +2.42
js:+2.25
css:+0.17
🆗 234.66 - 286.81
@epam/uui-core 333.83 336.86 +3.03
js:+3.03
css:0
🆗 300.45 - 367.21
@epam/uui-db 44.7 44.7 0
js:0
css:0
🆗 40.23 - 49.17
@epam/uui-docs 206.75 207.1 +0.36
js:+0.37
css:-0.01
🆗 186.07 - 227.43
@epam/uui-editor 181.56 183.62 +2.06
js:+1.83
css:+0.23
🆗 163.41 - 199.72
@epam/uui-timeline 77.95 79.51 +1.55
js:+1.55
css:+0
🆗 70.16 - 85.75
@epam/uui 601.25 606.64 +5.41
js:+1.79
css:+3.62
🆗 541.12 - 661.37
new sizes (raw)

To set the sizes as a new baseline, you can copy/paste next content to the uui-build/config/bundleSizeBaseLine.json and commit the file.

{
  "version": "5.9.2",
  "timestamp": "2024-10-09",
  "sizes": {
    "templateApp": {
      "css": 299908,
      "js": 479556
    },
    "@epam/app": {
      "css": 1621719,
      "js": 5129580
    },
    "@epam/draft-rte": {
      "css": 9776,
      "js": 45300
    },
    "@epam/electric": {
      "css": 2289,
      "js": 2409
    },
    "@epam/promo": {
      "css": 47617,
      "js": 10894
    },
    "@epam/uui-extra": {
      "css": 0,
      "js": 213
    },
    "@epam/loveship": {
      "css": 53466,
      "js": 42556
    },
    "@epam/uui-components": {
      "css": 22488,
      "js": 246981
    },
    "@epam/uui-core": {
      "css": 0,
      "js": 344945
    },
    "@epam/uui-db": {
      "css": 0,
      "js": 45769
    },
    "@epam/uui-docs": {
      "css": 2440,
      "js": 209637
    },
    "@epam/uui-editor": {
      "css": 12742,
      "js": 175290
    },
    "@epam/uui-timeline": {
      "css": 2255,
      "js": 79162
    },
    "@epam/uui": {
      "css": 277683,
      "js": 343526
    }
  }
}

Generated by: generate-components-api
CI Status: ok

Total amount of exported types/props without JSDoc comments

Amount
Types 300 (+0) 🆗
Props 233 (+0) 🆗

@AlekseyManetov AlekseyManetov merged commit f7c6a07 into develop Oct 9, 2024
3 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant