Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[LazyListView]: fixed backgroundReload functionality. #1821

Merged
merged 3 commits into from
Dec 7, 2023

Conversation

Kuznietsov
Copy link
Collaborator

Summary

Fixed showing blocker when filter/sorting changed.
Fixed showing placeholders while backgroundReload=true and placeholders should not appear.

@Kuznietsov Kuznietsov self-assigned this Dec 7, 2023
Copy link

github-actions bot commented Dec 7, 2023

Bundle size diff (in kBytes). Not gzipped. Both CSS & JS included.
Baseline: v5.4.1 (2023-12-06)
Generated by: track-bundle-size. Exceeds Limits: no
Generated at: Thu, 07 Dec 2023 11:09:04 GMT

Module Baseline Size (v5.4.1) Size Diff Within Threshold Threshold (min - max)
templateApp 1043.31 1043.31 0 🆗 938.98 - 1147.64
@epam/app 8426.98 8426.98 +0 🆗 7584.28 - 9269.68
@epam/draft-rte 56.73 56.73 0 🆗 51.06 - 62.41
@epam/electric 25.74 25.74 0 🆗 23.16 - 28.31
@epam/promo 79.3 79.3 0 🆗 71.37 - 87.23
@epam/uui-extra 0.21 0.21 0 🆗 0.19 - 0.24
@epam/loveship 152.67 152.67 0 🆗 137.4 - 167.94
@epam/uui-components 278.43 278.43 0 🆗 250.58 - 306.27
@epam/uui-core 275.67 275.66 -0.01 🆗 248.1 - 303.24
@epam/uui-db 44.47 44.47 0 🆗 40.02 - 48.92
@epam/uui-docs 176.44 176.44 0 🆗 158.79 - 194.08
@epam/uui-editor 175.51 175.51 0 🆗 157.96 - 193.06
@epam/uui-timeline 49.12 49.12 0 🆗 44.21 - 54.03
@epam/uui 557.19 557.19 0 🆗 501.47 - 612.91
new sizes (raw)

To set the sizes as a new baseline, you can copy/paste next content to the uui-build/config/bundleSizeBaseLine.json and commit the file.

{
  "version": "5.4.1",
  "timestamp": "2023-12-07",
  "sizes": {
    "templateApp": 1068346,
    "@epam/app": 8629232,
    "@epam/draft-rte": 58093,
    "@epam/electric": 26356,
    "@epam/promo": 81205,
    "@epam/uui-extra": 219,
    "@epam/loveship": 156332,
    "@epam/uui-components": 285108,
    "@epam/uui-core": 282280,
    "@epam/uui-db": 45539,
    "@epam/uui-docs": 180673,
    "@epam/uui-editor": 179721,
    "@epam/uui-timeline": 50296,
    "@epam/uui": 570562
  }
}

@AlekseyManetov AlekseyManetov merged commit 040a850 into develop Dec 7, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants