Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PlateEditor] Allow caption after pasting image #1744

Merged
merged 3 commits into from
Nov 13, 2023

Conversation

dimaanj
Copy link
Collaborator

@dimaanj dimaanj commented Nov 11, 2023

Summary

#1683

Follow up for #1697

Allow captioin after pasting images.

@dimaanj dimaanj self-assigned this Nov 11, 2023
Copy link

github-actions bot commented Nov 11, 2023

Bundle size diff (in kBytes). Not gzipped. Both CSS & JS included.
Baseline: v5.1.3 (2023-09-07)
Generated by: track-bundle-size. Exceeds Limits: no
Generated at: Mon, 13 Nov 2023 15:54:57 GMT

Module Baseline Size (v5.1.3) Size Diff Within Threshold Threshold (min - max)
templateApp 987.7 940.14 -47.56 🆗 888.93 - 1086.46
@epam/app 6102.33 6266.5 +164.17 🆗 5492.09 - 6712.56
@epam/draft-rte 55.62 55.56 -0.06 🆗 50.06 - 61.18
@epam/promo 95.89 95.91 +0.01 🆗 86.3 - 105.48
@epam/uui-extra 0.21 0.21 0 🆗 0.19 - 0.24
@epam/loveship 178.96 179.54 +0.58 🆗 161.07 - 196.86
@epam/uui-components 276.58 274.04 -2.54 🆗 248.92 - 304.24
@epam/uui-core 267.2 274.29 +7.09 🆗 240.48 - 293.92
@epam/uui-db 44.47 44.47 0 🆗 40.02 - 48.92
@epam/uui-docs 101.5 101.62 +0.12 🆗 91.35 - 111.65
@epam/uui-editor 178.55 179.08 +0.53 🆗 160.7 - 196.41
@epam/uui-timeline 49.12 49.12 +0 🆗 44.21 - 54.03
@epam/uui 413.7 415.6 +1.91 🆗 372.33 - 455.07
new sizes (raw)

To set the sizes as a new baseline, you can copy/paste next content to the uui-build/config/bundleSizeBaseLine.json and commit the file.

{
  "version": "5.2.0",
  "timestamp": "2023-11-13",
  "sizes": {
    "templateApp": 962702,
    "@epam/app": 6416899,
    "@epam/draft-rte": 56892,
    "@epam/promo": 98208,
    "@epam/uui-extra": 219,
    "@epam/loveship": 183846,
    "@epam/uui-components": 280621,
    "@epam/uui-core": 280876,
    "@epam/uui-db": 45539,
    "@epam/uui-docs": 104063,
    "@epam/uui-editor": 183378,
    "@epam/uui-timeline": 50299,
    "@epam/uui": 425577
  }
}

uui-editor/src/plugins/imagePlugin/ImageElement.tsx Outdated Show resolved Hide resolved
changelog.md Outdated Show resolved Hide resolved
@AlekseyManetov AlekseyManetov merged commit fe987f7 into develop Nov 13, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants