Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix/1663 dropdown menu button icon bug #1684

Conversation

dalalvarun
Copy link
Contributor

Issue link(if exists): #1663

Description:

Upon investigation, it was found that isDisabled prop was not being passed to DropdownMenuButton's child IconButton. As a result, even if DropddownMenuButton was disabled, the icon would still look like enabled.

@github-actions
Copy link

github-actions bot commented Oct 6, 2023

Bundle size diff (in kBytes). Not gzipped. Both CSS & JS included.
Baseline: v5.1.3 (2023-09-07)
Generated by: track-bundle-size. Exceeds Limits: no
Generated at: Fri, 06 Oct 2023 14:01:13 GMT

Module Baseline Size (v5.1.3) Size Diff Within Threshold Threshold (min - max)
templateApp 987.7 988.67 +0.97 🆗 888.93 - 1086.46
@epam/app 6102.33 6176.93 +74.6 🆗 5492.09 - 6712.56
@epam/draft-rte 55.62 55.62 0 🆗 50.06 - 61.18
@epam/promo 95.89 95.96 +0.07 🆗 86.3 - 105.48
@epam/uui-extra 0.21 0.21 0 🆗 0.19 - 0.24
@epam/loveship 178.96 179.51 +0.55 🆗 161.07 - 196.86
@epam/uui-components 276.58 276.43 -0.15 🆗 248.92 - 304.24
@epam/uui-core 267.2 271.42 +4.21 🆗 240.48 - 293.92
@epam/uui-db 44.47 44.47 0 🆗 40.02 - 48.92
@epam/uui-docs 101.5 101.62 +0.12 🆗 91.35 - 111.65
@epam/uui-editor 178.55 178.84 +0.28 🆗 160.7 - 196.41
@epam/uui-timeline 49.12 49.12 0 🆗 44.21 - 54.03
@epam/uui 413.7 413.39 -0.31 🆗 372.33 - 455.07
new sizes (raw)

To set the sizes as a new baseline, you can copy/paste next content to the uui-build/config/bundleSizeBaseLine.json and commit the file.

{
  "version": "5.1.3",
  "timestamp": "2023-10-06",
  "sizes": {
    "templateApp": 1012395,
    "@epam/app": 6325174,
    "@epam/draft-rte": 56956,
    "@epam/promo": 98264,
    "@epam/uui-extra": 219,
    "@epam/loveship": 183823,
    "@epam/uui-components": 283066,
    "@epam/uui-core": 277929,
    "@epam/uui-db": 45539,
    "@epam/uui-docs": 104062,
    "@epam/uui-editor": 183129,
    "@epam/uui-timeline": 50296,
    "@epam/uui": 423307
  }
}

@AlekseyManetov AlekseyManetov merged commit 417c4f6 into epam:develop Oct 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants