Skip to content

Commit

Permalink
Revert '[Svg]: don't set fill attribute if it's not provided' change …
Browse files Browse the repository at this point in the history
…from 5.12.0 version. Because it turned out that many users relied on the previous behavior where the fill attribute was cleared by default. If you need to render icon with built-in fill, please look at this issue comment - #2684 (comment)
  • Loading branch information
AlekseyManetov committed Dec 17, 2024
1 parent 3d4de92 commit 759e355
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 1 deletion.
5 changes: 5 additions & 0 deletions changelog.md
Original file line number Diff line number Diff line change
@@ -1,3 +1,8 @@
# 5.12.1 - 17.12.2024
**What's Fixed**
* Revert '[Svg]: don't set fill attribute if it's not provided' change from 5.12.0 version. Because it turned out that many users relied on the previous behavior where the fill attribute was cleared by default. If you need to render icon with built-in fill, please look at this issue comment - https://github.com/epam/UUI/issues/2684#issuecomment-2548751434


# 5.12.0 - 12.12.2024

**What's New**
Expand Down
2 changes: 1 addition & 1 deletion uui-components/src/widgets/Svg.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -27,10 +27,10 @@ export const Svg = React.forwardRef<SVGSVGElement, SvgProps>((props, ref) => {

const svgProps: ISvgProps = {
className: cx(props.cx),
fill: fillColor,
...props.rawProps,
};

if (fillColor !== undefined) svgProps.fill = fillColor;
if (height !== undefined) svgProps.height = height;
if (width !== undefined) svgProps.width = width;

Expand Down

0 comments on commit 759e355

Please sign in to comment.